You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -88,22 +88,34 @@ function evaluate!(cache,f::SkeletonCellFieldPair,x::CellPoint)
88
88
end
89
89
90
90
#=
91
-
Fix for CellFieldAt{T}(parent::OperationCellField) for OperationCellField involving args which are not FEFunctions. It creates a problem with SkeletonCellFieldPair giving the wrong output or errors as it chooses the SkeletonCellFieldPair directly as the parent rather the parent CellField of the side of choice. In code terms it is the following:
91
+
Fix for CellFieldAt{T}(parent::OperationCellField) for OperationCellField
92
+
involving args which are not FEFunctions. It creates a problem with
93
+
SkeletonCellFieldPair giving the wrong output or errors as it chooses the
94
+
SkeletonCellFieldPair directly as the parent rather the parent CellField of the
95
+
side of choice. In code terms it is the following:
92
96
93
97
CellFieldAt{T}(OperationCellField) results in calling CellFieldAt{T}(operands).
94
-
Without this override, CellFieldAt{T}(a::SkeletonCellField) results in the CellFieldAt structure with parent as SkeletonCellField and not a.T side CellField, which is not correct! This resulting in errors and is not the intended behaviour to have the parent as SkeletonCellFieldPair and is not consistent with our getproperty rules.
98
+
Without this override, CellFieldAt{T}(a::SkeletonCellField) results in the
99
+
CellFieldAt structure with parent as SkeletonCellField and not a.T side
100
+
CellField, which is not correct! This resulting in errors and is not the
101
+
intended behaviour to have the parent as SkeletonCellFieldPair and is not
102
+
consistent with our getproperty rules.
95
103
=#
96
104
functionCellFieldAt{T}(parent::SkeletonCellFieldPair) where T
97
105
getproperty(parent,T)
98
106
end
99
107
100
-
# to handle the evaluation of SkeletonCellFieldPair at BoundaryTriangulation
101
-
# making it consistent with plus side choice of direct evaluation of SCFP
102
-
# in general this is the case when trian of CellField is not the same as
103
-
# that of the quadrature
104
-
# But we are protected from inconsistent behaviour at SkeletonTriangulation
105
-
# as it fails due to the ambiguity as the CellField at the SkeletonTrian
106
-
# for direct evaluations
108
+
#=
109
+
To handle the evaluation of SkeletonCellFieldPair at BoundaryTriangulation
110
+
making it consistent with plus side choice of direct evaluation of SCFP in
111
+
general this is the case when trian of CellField is not the same as that of the
112
+
quadrature.
113
+
But we are protected from inconsistent behaviour at SkeletonTriangulation as it
114
+
fails due to similar ambiguity as the CellField at the SkeletonTrian for direct
115
+
evaluations, so get_data doesn't create any side effects.
116
+
In case of BodyFittedTriangulation there is no hit to get_data directly and
0 commit comments