Skip to content

Commit 4825525

Browse files
Merge pull request #918 from gridap/patch-in-modal-C0-bases-for-1.9
Update ModalC0Bases.jl for Julia 1.9
2 parents 94419b8 + 2c83851 commit 4825525

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

NEWS.md

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2424
Since PR [#884](https://github.com/gridap/Gridap.jl/pull/884).
2525

2626
- Fixed `cell_dof_ids` for the case of vectorial `ConstantFESpace`. Since PR [#888](https://github.com/gridap/Gridap.jl/pull/888)
27+
- Fixed generation of Modal C0 bases for Julia 1.9. Since PR [#918](https://github.com/gridap/Gridap.jl/pull/918).
2728

2829
## [0.17.17] - 2023-02-24
2930

src/Polynomials/ModalC0Bases.jl

+3-3
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,8 @@ function _sort_by_nfaces!(terms::Vector{CartesianIndex{D}},orders) where D
266266
# Generate indices of n-faces and order s.t.
267267
# (1) dimension-increasing (2) lexicographic
268268
bin_rang_nfaces = tfill(0:1,Val{D}())
269-
bin_ids_nfaces = collect(Iterators.product(bin_rang_nfaces...))
270-
sum_bin_ids_nfaces = [sum(bin_ids_nfaces[i]) for i in eachindex(bin_ids_nfaces)]
269+
bin_ids_nfaces = vec(collect(Iterators.product(bin_rang_nfaces...)))
270+
sum_bin_ids_nfaces = sum.(bin_ids_nfaces)
271271
bin_ids_nfaces = permute!(bin_ids_nfaces,sortperm(sum_bin_ids_nfaces))
272272

273273
# Generate LIs of basis funs s.t. order by n-faces
@@ -529,4 +529,4 @@ function _hessian_nd_mc0!(
529529

530530
end
531531

532-
end
532+
end

0 commit comments

Comments
 (0)