test(payments, create-initial-pr): add simple-mock

lib/payments.js

@@ -49,8 +49,8 @@ async function getAccountNeedsMarketplaceUpgrade (accountId) {
   if (paymentDoc.plan === 'opensource') return true
   if (paymentDoc.plan === 'team') {
     console.log('***TEAM***')
-    console.log('***Repos***', await getCurrentlyPrivateAndEnabledRepos(accountId))
-    if (await getCurrentlyPrivateAndEnabledRepos(accountId) >= 15) {
+    console.log('***Repos***', await module.exports.getCurrentlyPrivateAndEnabledRepos(accountId))
+    if (await module.exports.getCurrentlyPrivateAndEnabledRepos(accountId) >= 15) {
       console.log('***TEAM OVER LIMIT***')
       return true // team plan & repo limit reached
     }

package.json

@@ -36,6 +36,7 @@
     "nyc": "^11.0.3",
     "prettier-standard-formatter": "^0.222222222222222.333333333333333",
     "proxyquire": "^1.7.10",
+    "simple-mock": "^0.8.0",
     "standard": "^10.0.2",
     "tap": "^10.0.1"
   },

test/jobs/create-initial-pr.js

@@ -1,6 +1,6 @@
 const { test, tearDown } = require('tap')
 const nock = require('nock')
-const proxyquire = require('proxyquire')
+const simple = require('simple-mock')
 
 const dbs = require('../../lib/dbs')
 const createInitial = require('../../jobs/create-initial-pr')
@@ -350,6 +350,8 @@ test('create-initial-pr', async t => {
   })
 
   t.test('create pr for private repo and account with Github `team` plan with payment required', async t => {
+    const payments = require('../../lib/payments')
+
     await repositories.put({
       _id: '44b',
       accountId: '123team',
@@ -400,15 +402,9 @@ test('create-initial-pr', async t => {
         return {}
       })
 
-    const worker = proxyquire('../../jobs/create-initial-pr', {
-      '../lib/payments': {
-        'getCurrentlyPrivateAndEnabledRepos': async (accountId) => { // Help!  not working!
-          return 15
-        }
-      }
-    })
+    simple.mock(payments, 'getCurrentlyPrivateAndEnabledRepos').returnWith(15)
 
-    await worker({
+    await createInitial({
       repository: { id: '44b' },
       branchDoc: branchDoc,
       combined: {
@@ -418,6 +414,7 @@ test('create-initial-pr', async t => {
       installationId: 11,
       accountId: '123team'
     })
+    simple.restore()
   })
 
   t.test('create pr for private repo and account with Github `business` plan', async t => {

test/lib/payments.js

@@ -1,5 +1,5 @@
 const { test, tearDown } = require('tap')
-const proxyquire = require('proxyquire')
+const simple = require('simple-mock')
 
 const dbs = require('../../lib/dbs')
 const { getActiveBilling, maybeUpdatePaymentsJob, hasStripeBilling, getAccountNeedsMarketplaceUpgrade } = require(
@@ -165,12 +165,11 @@ test('payments', async t => {
   })
 
   t.test('getAccountNeedsMarketplaceUpgrade with `team` plan and reached repo limit', async t => {
-    const { getAccountNeedsMarketplaceUpgrade } = proxyquire('../../lib/payments', { // Help! can't get this to be overwritten
-      './getCurrentlyPrivateAndEnabledRepos': async (accountId) => {
-        return 15
-      }
-    })
+    const payments = require('../../lib/payments')
+    simple.mock(payments, 'getCurrentlyPrivateAndEnabledRepos').resolveWith(15)
     const result = await getAccountNeedsMarketplaceUpgrade('123team')
+    simple.restore()
+
     t.ok(result)
     t.end()
   })