Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP/VLAN hack and broadcast breakage on QCA988X #177

Open
pxnky opened this issue Feb 13, 2021 · 0 comments
Open

AP/VLAN hack and broadcast breakage on QCA988X #177

pxnky opened this issue Feb 13, 2021 · 0 comments

Comments

@pxnky
Copy link

pxnky commented Feb 13, 2021

Running a patched openwrt 19.07.6 on a Unifi AP AC Pro and dynamic vlans were not working on the 5ghz radio (ath10k) but were working on the 2.4ghz radio (ath9k).. In an attempt to fix it I found #134 and applied this patch:

@@ -9995,7 +9944,10 @@ int ath10k_mac_register(struct ath10k *a
                goto err_dfs_detector_exit;
        }

-       if (test_bit(WMI_SERVICE_PER_PACKET_SW_ENCRYPT, ar->wmi.svc_map)) {
+       if (test_bit(WMI_SERVICE_PER_PACKET_SW_ENCRYPT, ar->wmi.svc_map) ||
+           test_bit(ATH10K_FW_FEATURE_CONSUME_BLOCK_ACK_CT, ar->normal_mode_fw.fw_file.fw_features)) {
+                       /* assume enough raw tx support for VLAN if a recent CT
+                        * firmware is detected. */
                ar->hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
                ar->hw->wiphy->software_iftypes |= BIT(NL80211_IFTYPE_AP_VLAN);
        }

This fixed dynamic vlans for me but now I've realized broadcast traffic is not passing on that radio.

[   11.803364] ath10k 4.19 driver, optimized for CT firmware, probing pci device: 0x3c.
[   14.503893] ath10k_pci 0000:00:00.0: firmware ver 10.1-ct-8x-__fW-022-538f0906 api 2 features wmi-10.x,has-wmi-mgmt-tx,mfp,txstatus-noack,wmi-10.x-CT,ratemask-CT,txrate-CT,get-temp-CT,tx-rc-CT,cust-stats-CT,retry-gt2-CT,txrate2-CT,beacon-cb-CT,wmi-block-ack-CT crc32 e1c91a74

Anything I can try/test or more information I can supply would be appreciated! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant