Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

Fix: Generating screenshots/pdf using os.tmpdir() for Windows #172

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Fix: Generating screenshots/pdf using os.tmpdir() for Windows #172

merged 1 commit into from
Aug 4, 2017

Conversation

Kivol
Copy link
Contributor

@Kivol Kivol commented Aug 4, 2017

Since Windows does not use the temporary directory on /tmp, so the usage of os.tmpdir() is needed.

Copy link
Collaborator

@adieuadieu adieuadieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kivol — thank you for this! Looks good to me. Also thank you for including a test! 🥇

Notes (to myself):

@elisherer
Copy link
Contributor

@adieuadieu, actually I did both pdf and screenshot on my PR, the only thing I miss are tests, would you like us to join forces?

@adieuadieu
Copy link
Collaborator

@elisherer I think what we'll do is merge this PR, and then we can merge your PR #137 as it adds even more on top of what this PR adds. Effectively we'll get this PRs test, plus your contributions in #137.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants