-
Notifications
You must be signed in to change notification settings - Fork 575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for raising this PR, @criticalbh.
Two points:
- We need to think about how this would work over the Proxy. E.g. we might need to add support for uploading from an S3 bucket or other URL. e.g.
await chromeless.selectFile('.uploader', [
's3://my-bucket/my/object/prefix/file.jpg',
'http://sweet-site.cool/my-image.jpg'
])
- I wonder if we could keep the API methods as just one which can take either a single file path string, or an array of file path strings. Maybe something like
.selectFileInput(filePathString | array[filePathString])
? (I know we've already asked you to change the name once—sorry!) What do you think @schickling @joelgriffith @timsuchanek ?
Sorry for the back and forth on this but I agree with @adieuadieu. We should go with |
@schickling I lean towards |
I'm ready for a bike-shed! |
@joelgriffith Ah shoot. You're right. |
Why not like CDT api -> setFileInputFiles? |
@joelgriffith @schickling @criticalbh Naming stuff is hard. Since we sort of liked |
I like that proposal. Let's do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go once we've renamed to setFileInput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, @criticalbh!
#148
#100