Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

feat: focus dom element #132

Merged
merged 3 commits into from
Aug 1, 2017
Merged

Conversation

criticalbh
Copy link
Contributor

I have changed util focus method to https://chromedevtools.github.io/devtools-protocol/tot/DOM/#method-focus. If you prefer eval methods over this one I will change it.

However there is one small issue with combination of focus and press. Both implementations of focus dont work well with press. I dont know if that has something with my local environment.

@joelgriffith
Copy link
Contributor

You're killing it! Nice work

@criticalbh
Copy link
Contributor Author

criticalbh commented Aug 1, 2017

@joelgriffith Thanks

Copy link
Owner

@schickling schickling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@schickling
Copy link
Owner

Good to go @joelgriffith :shipit:

@mndominguez
Copy link

@criticalbh care to mention what the issue with the combination between focus and press is? Thanks!

Copy link
Collaborator

@adieuadieu adieuadieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to update the CHANGELOG 😄

@criticalbh
Copy link
Contributor Author

criticalbh commented Aug 1, 2017

@mndominguez press does not send the code to Google Chrome Canapy after focus action, it actually opens Settings page. However press in extract-google-results.js works perfectly. But it should be tested better.

@joelgriffith joelgriffith merged commit 7f466cd into schickling:master Aug 1, 2017
@criticalbh criticalbh deleted the feature/focus branch August 1, 2017 22:42
@dagumak
Copy link

dagumak commented Sep 23, 2017

@criticalbh I'm actually having an issue with open(13) opening the Settings page. How do I stop it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants