Skip to content

Commit 4801274

Browse files
authored
Merge pull request #1624 from grafana/fix/omitempty-status-on-folder
fix: remove required attribute from folder conditions
2 parents c3ffb02 + d9f95a4 commit 4801274

File tree

5 files changed

+8
-14
lines changed

5 files changed

+8
-14
lines changed

api/v1beta1/grafanafolder_types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ type GrafanaFolderStatus struct {
7272
NoMatchingInstances bool `json:"NoMatchingInstances,omitempty"`
7373
// Last time the folder was resynced
7474
LastResync metav1.Time `json:"lastResync,omitempty"`
75-
Conditions []metav1.Condition `json:"conditions"`
75+
Conditions []metav1.Condition `json:"conditions,omitempty"`
7676
}
7777

7878
//+kubebuilder:object:root=true

config/crd/bases/grafana.integreatly.org_grafanafolders.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,6 @@ spec:
212212
description: Last time the folder was resynced
213213
format: date-time
214214
type: string
215-
required:
216-
- conditions
217215
type: object
218216
type: object
219217
served: true

deploy/helm/grafana-operator/crds/grafana.integreatly.org_grafanafolders.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,6 @@ spec:
212212
description: Last time the folder was resynced
213213
format: date-time
214214
type: string
215-
required:
216-
- conditions
217215
type: object
218216
type: object
219217
served: true

deploy/kustomize/base/crds.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -1441,8 +1441,6 @@ spec:
14411441
description: Last time the folder was resynced
14421442
format: date-time
14431443
type: string
1444-
required:
1445-
- conditions
14461444
type: object
14471445
type: object
14481446
served: true

docs/docs/api.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -2735,19 +2735,19 @@ GrafanaFolderStatus defines the observed state of GrafanaFolder
27352735
</tr>
27362736
</thead>
27372737
<tbody><tr>
2738-
<td><b><a href="#grafanafolderstatusconditionsindex">conditions</a></b></td>
2739-
<td>[]object</td>
2740-
<td>
2741-
<br/>
2742-
</td>
2743-
<td>true</td>
2744-
</tr><tr>
27452738
<td><b>NoMatchingInstances</b></td>
27462739
<td>boolean</td>
27472740
<td>
27482741
The folder instanceSelector can't find matching grafana instances<br/>
27492742
</td>
27502743
<td>false</td>
2744+
</tr><tr>
2745+
<td><b><a href="#grafanafolderstatusconditionsindex">conditions</a></b></td>
2746+
<td>[]object</td>
2747+
<td>
2748+
<br/>
2749+
</td>
2750+
<td>false</td>
27512751
</tr><tr>
27522752
<td><b>hash</b></td>
27532753
<td>string</td>

0 commit comments

Comments
 (0)