feat: commit kafka offsets on successful read #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballiet
changed the title
anaselmhamdi
approved these changes
Jan 9, 2025
anaselmhamdi
deleted the
antoineballiet/daae-4573-commit-offsets-in-kafka-from-source
branch
aballiet
added a commit
that referenced
this pull request
Jan 23, 2025
* fix: add infer_schema_length=None to polars transfo (#9) * fix: raise warning when MSG_SIZE_TOO_LARGE and skip (#10) * fix: raise warning when MSG_SIZE_TOO_LARGE and skip * fix: update pagination to only existing messages * format * dummy * fix increment * feat: Slack alerting (#12) * chore: update gitignore * chore: update gitignore * chore: lint * chore: add log levels and e2e testing * feat: commit offsets on successfull read (#11) * chore: add reusable address (#13) * chore: change log to info when no records to write * chore: change log to info when total records mismatch * fea: add datadog monitoring (#14) * fea: add datadog monitoring * chore: remove prometheus and otel * chore: handle no datadog * chore: lint --------- Co-authored-by: Anas El Mhamdi <anas.elmhamdi@gmail.com>
anaselmhamdi
added a commit
that referenced
this pull request
Jan 23, 2025
* feat: monitoring (datadog) and alerting (slack) (#20) * fix: add infer_schema_length=None to polars transfo (#9) * fix: raise warning when MSG_SIZE_TOO_LARGE and skip (#10) * fix: raise warning when MSG_SIZE_TOO_LARGE and skip * fix: update pagination to only existing messages * format * dummy * fix increment * feat: Slack alerting (#12) * chore: update gitignore * chore: update gitignore * chore: lint * chore: add log levels and e2e testing * feat: commit offsets on successfull read (#11) * chore: add reusable address (#13) * chore: change log to info when no records to write * chore: change log to info when total records mismatch * fea: add datadog monitoring (#14) * fea: add datadog monitoring * chore: remove prometheus and otel * chore: handle no datadog * chore: lint --------- Co-authored-by: Anas El Mhamdi <anas.elmhamdi@gmail.com> * chore: add extra poetry --------- Co-authored-by: Antoine Balliet <antoine.balliet@gmail.com>
aballiet
added a commit
that referenced
this pull request
Feb 12, 2025
aballiet
added a commit
that referenced
this pull request
Feb 12, 2025
* feat: monitoring (datadog) and alerting (slack) (#20) * fix: add infer_schema_length=None to polars transfo (#9) * fix: raise warning when MSG_SIZE_TOO_LARGE and skip (#10) * fix: raise warning when MSG_SIZE_TOO_LARGE and skip * fix: update pagination to only existing messages * format * dummy * fix increment * feat: Slack alerting (#12) * chore: update gitignore * chore: update gitignore * chore: lint * chore: add log levels and e2e testing * feat: commit offsets on successfull read (#11) * chore: add reusable address (#13) * chore: change log to info when no records to write * chore: change log to info when total records mismatch * fea: add datadog monitoring (#14) * fea: add datadog monitoring * chore: remove prometheus and otel * chore: handle no datadog * chore: lint --------- Co-authored-by: Anas El Mhamdi <anas.elmhamdi@gmail.com> * chore: add extra poetry --------- Co-authored-by: Antoine Balliet <antoine.balliet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit Kafka offsets so we can track lag using Confluent Cloud / Datadog