-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation #82
fix: Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation #82
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 28 28
Lines 172 186 +14
Branches 26 26
======================================
- Misses 172 186 +14
Continue to review full report at Codecov.
|
47fc9d9
to
1503ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending us a PR! I have one stylistic comment, other than that, it looks good to me.
maps-ktx/src/main/java/com/google/maps/android/ktx/GoogleMap.kt
Outdated
Show resolved
Hide resolved
…): Flow<CameraEvent> implementation and remove unnecessary inline.
1503ee8
to
3888baa
Compare
## [2.1.1](v2.1.0...v2.1.1) (2020-07-21) ### Bug Fixes * Remove listeners in awaitClose block in GoogleMaps.cameraEvents(): Flow<CameraEvent> implementation and remove unnecessary inline. ([#82](#82)) ([7756605](7756605))
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes #80.
awaitClose
within theGoogleMap.cameraEvents(): Flow<CameraEvent>
implementation.inline
keyword as the function has no parameters of function types.Also made a couple of unrelated changes (let me know if you want them in a separate PR):
kotlin-stdlib-jdk7
tokotlin-stdlib
as no Java 7 APIs are used.Ran
./gradlew assemble check
locally.