From 524b09501c014d0335208c71803c8d1e18ba27a2 Mon Sep 17 00:00:00 2001 From: Joe Wang Date: Sat, 18 Mar 2023 20:00:54 -0400 Subject: [PATCH 1/5] feat: install clirr check --- .github/workflows/ci-maven.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci-maven.yaml b/.github/workflows/ci-maven.yaml index 2540ce063b..c24bb3c032 100644 --- a/.github/workflows/ci-maven.yaml +++ b/.github/workflows/ci-maven.yaml @@ -20,6 +20,11 @@ jobs: distribution: temurin cache: maven - run: java -version + - name: Compatibility check + run: | + # package jar so that gapic-generator-java module can use + # testlib modules of gax + mvn package clirr:check -DskipTests - name: Unit Tests run: | mvn test --batch-mode --no-transfer-progress -Dcheckstyle.skip \ From 914676aee7a7b005e79d95aff2f1cd5475ee6c86 Mon Sep 17 00:00:00 2001 From: Joe Wang Date: Sun, 19 Mar 2023 09:22:01 -0400 Subject: [PATCH 2/5] install an independent action --- .github/workflows/ci-maven.yaml | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-maven.yaml b/.github/workflows/ci-maven.yaml index c24bb3c032..be0aff3a2d 100644 --- a/.github/workflows/ci-maven.yaml +++ b/.github/workflows/ci-maven.yaml @@ -20,11 +20,6 @@ jobs: distribution: temurin cache: maven - run: java -version - - name: Compatibility check - run: | - # package jar so that gapic-generator-java module can use - # testlib modules of gax - mvn package clirr:check -DskipTests - name: Unit Tests run: | mvn test --batch-mode --no-transfer-progress -Dcheckstyle.skip \ @@ -156,6 +151,21 @@ jobs: # Exclude the root project run: mvn -B -ntp fmt:check + compatibility check: + runs-on: ubuntu-22.04 + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-java@v3 + with: + java-version: 11 + distribution: temurin + cache: maven + - run: java -version + - name: Java Linter + # package jar so that gapic-generator-java module can use + # testlib modules of gax + run: mvn package clirr:check -DskipTests + showcase: runs-on: ubuntu-22.04 strategy: From 0dd990af9fd21d326301d99860d9e5a206429d7b Mon Sep 17 00:00:00 2001 From: Joe Wang Date: Sun, 19 Mar 2023 09:23:16 -0400 Subject: [PATCH 3/5] format changes --- .github/workflows/ci-maven.yaml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci-maven.yaml b/.github/workflows/ci-maven.yaml index be0aff3a2d..19af179000 100644 --- a/.github/workflows/ci-maven.yaml +++ b/.github/workflows/ci-maven.yaml @@ -154,17 +154,17 @@ jobs: compatibility check: runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3 - - uses: actions/setup-java@v3 - with: - java-version: 11 - distribution: temurin - cache: maven - - run: java -version - - name: Java Linter - # package jar so that gapic-generator-java module can use - # testlib modules of gax - run: mvn package clirr:check -DskipTests + - uses: actions/checkout@v3 + - uses: actions/setup-java@v3 + with: + java-version: 11 + distribution: temurin + cache: maven + - run: java -version + - name: Java Linter + # package jar so that gapic-generator-java module can use + # testlib modules of gax + run: mvn package clirr:check -DskipTests showcase: runs-on: ubuntu-22.04 From 1c64339fe2f15477fd41124a4b391095faca7f5f Mon Sep 17 00:00:00 2001 From: Joe Wang Date: Sun, 19 Mar 2023 09:26:03 -0400 Subject: [PATCH 4/5] change name --- .github/workflows/ci-maven.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-maven.yaml b/.github/workflows/ci-maven.yaml index 19af179000..a16c30e026 100644 --- a/.github/workflows/ci-maven.yaml +++ b/.github/workflows/ci-maven.yaml @@ -161,7 +161,7 @@ jobs: distribution: temurin cache: maven - run: java -version - - name: Java Linter + - name: Compatibility check # package jar so that gapic-generator-java module can use # testlib modules of gax run: mvn package clirr:check -DskipTests From 98dd825f5ee6c3c1a59b22572ffd26f2bda49fc9 Mon Sep 17 00:00:00 2001 From: Joe Wang Date: Sun, 19 Mar 2023 09:27:12 -0400 Subject: [PATCH 5/5] change action name --- .github/workflows/ci-maven.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-maven.yaml b/.github/workflows/ci-maven.yaml index a16c30e026..7c0ed6333d 100644 --- a/.github/workflows/ci-maven.yaml +++ b/.github/workflows/ci-maven.yaml @@ -151,7 +151,7 @@ jobs: # Exclude the root project run: mvn -B -ntp fmt:check - compatibility check: + compatibility: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3