Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the impact of changing ClientConext's getEndpoint() on downstream Handwritten Libraries #2295

Closed
lqiu96 opened this issue Dec 8, 2023 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Dec 8, 2023

Modifying this value:

to be the resolved endpoint from the EndpointContext may break downstream handwritten libraries.

If there is no impact, try to change the value.
If there is impact and ClientContext needs to return the resolvedEndpoint, look into exposing a few field to return

@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 8, 2023
@lqiu96
Copy link
Contributor Author

lqiu96 commented May 21, 2024

ClientContext's getEndpoint() returns the StubSettings' getEndpoint() value which is the resolved endpoint. When data is passed between ClientContext and StubSettings, all the the endpoint information is passed between the two. StubSettings will recreated the EndpointContext with the original values so any user configurations will not be lost.

Going to close this issue as this was done in #2715

@lqiu96 lqiu96 closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant