-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Bucket.reload() and Bucket.update() wrappers to restrict generation match args #153
feat: add Bucket.reload() and Bucket.update() wrappers to restrict generation match args #153
Conversation
…neration match args
@andrewsg, @frankyn, I've taken one more self review and found the thing, that got no our attention yet. We have only two All of the above methods are inherited from I'm proposing to add wrapper methods into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying this proactively!
LGTM but I'll pass this by Frank before merging just in case I'm missing something. |
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
1 similar comment
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
…neration match args (googleapis#153) Towards googleapis#127
…neration match args (googleapis#153) Towards googleapis#127
Towards #127