Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation in decimal to numeric conversion #339

Closed
vi3k6i5 opened this issue May 12, 2021 · 0 comments · Fixed by #340 or #350
Closed

Add validation in decimal to numeric conversion #339

vi3k6i5 opened this issue May 12, 2021 · 0 comments · Fixed by #340 or #350
Assignees
@vi3k6i5
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vi3k6i5
Copy link
Contributor

vi3k6i5 commented May 12, 2021

Add validation in decimal to numeric conversion to ensure precision and recall is supported by spanner.

read more here: https://cloud.google.com/spanner/docs/data-types#numeric_type.

Similar validations are present in other clients eg: https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java#L141-L155
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label May 12, 2021
@vi3k6i5 vi3k6i5 mentioned this issue May 12, 2021
Merged
@vi3k6i5 vi3k6i5 assigned vi3k6i5 and unassigned larkee May 12, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 14, 2021
@larkee larkee added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels May 17, 2021
@vi3k6i5 vi3k6i5 mentioned this issue May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vi3k6i5 vi3k6i5

Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@vi3k6i5 @larkee @yoshi-automation