Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add install reference for cloud trace exporter (opentelemetry) #127

Merged
merged 4 commits into from
Aug 7, 2020
Merged

docs: add install reference for cloud trace exporter (opentelemetry) #127

merged 4 commits into from
Aug 7, 2020

Conversation

cnnradams
Copy link
Contributor

The example uses the Cloud Trace exporter, but there is no pip install mentioned for it in the example.

+ misc doc fixes

@cnnradams cnnradams requested a review from a team as a code owner August 5, 2020 18:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
@hengfengli hengfengli added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 5, 2020

Likely needs to have PR #124 merged before the main Kokoro build will pass.

hengfengli
hengfengli approved these changes Aug 5, 2020
View reviewed changes
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hengfengli hengfengli added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@cnnradams cnnradams force-pushed the opentelemetry-tracing branch from 0d8dabe to 82bcedf Compare August 6, 2020 15:40
@hengfengli
Copy link

hengfengli commented Aug 6, 2020 •
edited
Loading

@larkee Could you please help to rebase this PR? I can't do it because the associated email is not my google address.

Do you have any idea why Kokoro docs-presubmit fails? I tried to check the invocation log, but it is empty.

I think the failed test is not caused by this change. It happens in another PR as well: #129.

@hengfengli hengfengli added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@larkee
Copy link
Contributor

larkee commented Aug 7, 2020

@larkee Could you please help to rebase this PR? I can't do it because the associated email is not my google address.

Do you have any idea why Kokoro docs-presubmit fails? I tried to check the invocation log, but it is empty.

I think the failed test is not caused by this change. It happens in another PR as well: #129.

The docs-presubmit is a new CI test that is relying on files that don't yet exist. I'm working on fixing this in #126. I'll prioritize that to unblock this change 👍

cnnradams and others added 2 commits August 6, 2020 22:09
@cnnradams @larkee
Update docs/opentelemetry-tracing.rst
2e2afc0 
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
@larkee
Merge branch 'master' into opentelemetry-tracing
9e7505f
@hengfengli hengfengli added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 7, 2020
@larkee larkee added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 23fcd4c into googleapis:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnnradams @tseaver @hengfengli @larkee @yoshi-kokoro