Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: implement a base test class to set up engine and metadata #138

Closed
IlyaFaer opened this issue Nov 3, 2021 · 0 comments · Fixed by #158
Closed

test: implement a base test class to set up engine and metadata #138

IlyaFaer opened this issue Nov 3, 2021 · 0 comments · Fixed by #158
Assignees
@IlyaFaer
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@IlyaFaer
Copy link
Contributor

IlyaFaer commented Nov 3, 2021

See the original comment:
https://github.com/googleapis/python-spanner-sqlalchemy/pull/134/files#r738004275
@IlyaFaer IlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 3, 2021
@IlyaFaer IlyaFaer self-assigned this Nov 3, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Nov 3, 2021
@IlyaFaer IlyaFaer mentioned this issue Nov 3, 2021
Merged
@IlyaFaer IlyaFaer mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaFaer IlyaFaer

Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add base class for the Spanner specific tests googleapis/python-spanner-sqlalchemy
1 participant
@IlyaFaer