Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: advise setting 'CRC32C_PURE_PYTHON' after build failure #84

Merged
merged 4 commits into from
Sep 1, 2021
Merged

fix: advise setting 'CRC32C_PURE_PYTHON' after build failure #84

merged 4 commits into from
Sep 1, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 31, 2021

Toward #83.

@tseaver tseaver requested a review from andrewsg August 31, 2021 22:37
@tseaver tseaver requested a review from a team as a code owner August 31, 2021 22:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021
parthea
parthea approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 minor observations, otherwise LGTM.

@tseaver @parthea
chore: support capitalized spellings for negative values
db04caf 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
andrewsg
andrewsg approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tseaver tseaver merged commit 6aa1cd6 into main Sep 1, 2021
@tseaver tseaver deleted the 83-emit-warning-for-build-failure branch September 1, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@parthea parthea parthea approved these changes

Assignees

@andrewsg andrewsg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @andrewsg @parthea