Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

contrib.appengine uses its own InvalidClientSecretsError #465

Closed
theacodes opened this issue Mar 17, 2016 · 3 comments
Closed

contrib.appengine uses its own InvalidClientSecretsError #465

theacodes opened this issue Mar 17, 2016 · 3 comments
Labels
contrib hygiene

Comments

@theacodes
Copy link
Contributor

No description provided.

@pferate
Copy link
Contributor

pferate commented Jun 29, 2016

I don't see any reason within oauth2client to not change it to use clientsecrets.InvalidClientSecretsError.

I'm not sure if any major projects are trying to catch it.

I can make a PR for this, and leave it up to you guys on when to merge it in.

The other exception in that module is InvalidXsrfTokenError(Exception), and is not used outside of it. Should I just leave that as is, or have it extend a local base error for the module?

@theacodes
Copy link
Contributor Author

originally backwards compatibility, but I'm okay with breaking changes as long as they're in a major release.

@pferate pferate mentioned this issue Jun 29, 2016
Merged
@theacodes
Copy link
Contributor Author

Closed by #533

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contrib hygiene
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theacodes @pferate