Skip to content

Commit c94cc72

Browse files
AVaksmanJustinBeckwith
authored andcommitted
refactor: remove usage of async module (#702)
1 parent 42937a8 commit c94cc72

File tree

3 files changed

+304
-587
lines changed

3 files changed

+304
-587
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
"@google-cloud/paginator": "^1.0.0",
5555
"@google-cloud/promisify": "^1.0.0",
5656
"arrify": "^2.0.0",
57-
"async": "^2.0.1",
5857
"compressible": "^2.0.12",
5958
"concat-stream": "^2.0.0",
6059
"date-and-time": "^0.6.3",
@@ -107,6 +106,7 @@
107106
"node-fetch": "^2.2.0",
108107
"normalize-newline": "^3.0.0",
109108
"nyc": "^14.0.0",
109+
"p-limit": "^2.2.0",
110110
"power-assert": "^1.4.4",
111111
"prettier": "^1.7.0",
112112
"proxyquire": "^2.0.0",

src/bucket.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1099,7 +1099,7 @@ class Bucket extends ServiceObject {
10991099
combine(
11001100
sources: string[] | File[],
11011101
destination: string | File,
1102-
options: CombineOptions
1102+
options?: CombineOptions
11031103
): Promise<CombineResponse>;
11041104
combine(
11051105
sources: string[] | File[],
@@ -2773,7 +2773,7 @@ class Bucket extends ServiceObject {
27732773

27742774
setStorageClass(
27752775
storageClass: string,
2776-
options: SetBucketStorageClassOptions
2776+
options?: SetBucketStorageClassOptions
27772777
): Promise<SetBucketMetadataResponse>;
27782778
setStorageClass(
27792779
storageClass: string,
@@ -2827,7 +2827,7 @@ class Bucket extends ServiceObject {
28272827
*/
28282828
setStorageClass(
28292829
storageClass: string,
2830-
optionsOrCallback:
2830+
optionsOrCallback?:
28312831
| SetBucketStorageClassOptions
28322832
| SetBucketStorageClassCallback,
28332833
callback?: SetBucketStorageClassCallback

0 commit comments

Comments
 (0)