Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Commit e300534

Browse files
yoshi-automationchingor13
yoshi-automation
and
chingor13
authored
fix!: reorder Company and Job resources in talent API to be consistent with old gapic config (#143)
BREAKING CHANGE: The default `of` methods of CompanyName and JobName have changed. This should not happen again, but to insulate yourself, please use the specific `of[Named Type]Name()` * fix (breaking change): reorder Company and Job resources in talent API to be consistent with old gapic config. committer: @hzyi-google PiperOrigin-RevId: 305760190 Source-Author: Google APIs <noreply@google.com> Source-Date: Thu Apr 9 14:25:39 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: ac1f904979899bc598fb0567cf7a367f08b40b43 Source-Link: googleapis/googleapis@ac1f904 * chore: allow breaking changes Co-authored-by: Jeff Ching <chingor@google.com>
1 parent 55c00bc commit e300534

File tree

14 files changed

+217
-223
lines changed

14 files changed

+217
-223
lines changed

‎google-cloud-talent/src/main/java/com/google/cloud/talent/v4beta1/CompanyServiceClient.java

+9-9
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
* <pre>
4545
* <code>
4646
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
47-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
47+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
4848
* companyServiceClient.deleteCompany(name);
4949
* }
5050
* </code>
@@ -162,7 +162,7 @@ public CompanyServiceStub getStub() {
162162
*
163163
* <pre><code>
164164
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
165-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
165+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
166166
* companyServiceClient.deleteCompany(name);
167167
* }
168168
* </code></pre>
@@ -188,7 +188,7 @@ public final void deleteCompany(CompanyName name) {
188188
*
189189
* <pre><code>
190190
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
191-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
191+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
192192
* companyServiceClient.deleteCompany(name.toString());
193193
* }
194194
* </code></pre>
@@ -213,7 +213,7 @@ public final void deleteCompany(String name) {
213213
*
214214
* <pre><code>
215215
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
216-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
216+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
217217
* DeleteCompanyRequest request = DeleteCompanyRequest.newBuilder()
218218
* .setName(name.toString())
219219
* .build();
@@ -236,7 +236,7 @@ public final void deleteCompany(DeleteCompanyRequest request) {
236236
*
237237
* <pre><code>
238238
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
239-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
239+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
240240
* DeleteCompanyRequest request = DeleteCompanyRequest.newBuilder()
241241
* .setName(name.toString())
242242
* .build();
@@ -394,7 +394,7 @@ public final UnaryCallable<CreateCompanyRequest, Company> createCompanyCallable(
394394
*
395395
* <pre><code>
396396
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
397-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
397+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
398398
* Company response = companyServiceClient.getCompany(name);
399399
* }
400400
* </code></pre>
@@ -420,7 +420,7 @@ public final Company getCompany(CompanyName name) {
420420
*
421421
* <pre><code>
422422
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
423-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
423+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
424424
* Company response = companyServiceClient.getCompany(name.toString());
425425
* }
426426
* </code></pre>
@@ -445,7 +445,7 @@ public final Company getCompany(String name) {
445445
*
446446
* <pre><code>
447447
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
448-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
448+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
449449
* GetCompanyRequest request = GetCompanyRequest.newBuilder()
450450
* .setName(name.toString())
451451
* .build();
@@ -468,7 +468,7 @@ public final Company getCompany(GetCompanyRequest request) {
468468
*
469469
* <pre><code>
470470
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
471-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
471+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
472472
* GetCompanyRequest request = GetCompanyRequest.newBuilder()
473473
* .setName(name.toString())
474474
* .build();

‎google-cloud-talent/src/main/java/com/google/cloud/talent/v4beta1/JobServiceClient.java

+9-9
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
* <pre>
5050
* <code>
5151
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
52-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
52+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
5353
* jobServiceClient.deleteJob(name);
5454
* }
5555
* </code>
@@ -180,7 +180,7 @@ public final OperationsClient getOperationsClient() {
180180
*
181181
* <pre><code>
182182
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
183-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
183+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
184184
* jobServiceClient.deleteJob(name);
185185
* }
186186
* </code></pre>
@@ -208,7 +208,7 @@ public final void deleteJob(JobName name) {
208208
*
209209
* <pre><code>
210210
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
211-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
211+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
212212
* jobServiceClient.deleteJob(name.toString());
213213
* }
214214
* </code></pre>
@@ -235,7 +235,7 @@ public final void deleteJob(String name) {
235235
*
236236
* <pre><code>
237237
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
238-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
238+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
239239
* DeleteJobRequest request = DeleteJobRequest.newBuilder()
240240
* .setName(name.toString())
241241
* .build();
@@ -260,7 +260,7 @@ public final void deleteJob(DeleteJobRequest request) {
260260
*
261261
* <pre><code>
262262
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
263-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
263+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
264264
* DeleteJobRequest request = DeleteJobRequest.newBuilder()
265265
* .setName(name.toString())
266266
* .build();
@@ -601,7 +601,7 @@ public final UnaryCallable<BatchCreateJobsRequest, Operation> batchCreateJobsCal
601601
*
602602
* <pre><code>
603603
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
604-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
604+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
605605
* Job response = jobServiceClient.getJob(name);
606606
* }
607607
* </code></pre>
@@ -627,7 +627,7 @@ public final Job getJob(JobName name) {
627627
*
628628
* <pre><code>
629629
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
630-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
630+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
631631
* Job response = jobServiceClient.getJob(name.toString());
632632
* }
633633
* </code></pre>
@@ -652,7 +652,7 @@ public final Job getJob(String name) {
652652
*
653653
* <pre><code>
654654
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
655-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
655+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
656656
* GetJobRequest request = GetJobRequest.newBuilder()
657657
* .setName(name.toString())
658658
* .build();
@@ -675,7 +675,7 @@ public final Job getJob(GetJobRequest request) {
675675
*
676676
* <pre><code>
677677
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
678-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
678+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
679679
* GetJobRequest request = GetJobRequest.newBuilder()
680680
* .setName(name.toString())
681681
* .build();

‎google-cloud-talent/src/main/java/com/google/cloud/talent/v4beta1/package-info.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* <pre>
4646
* <code>
4747
* try (CompanyServiceClient companyServiceClient = CompanyServiceClient.create()) {
48-
* CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
48+
* CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
4949
* companyServiceClient.deleteCompany(name);
5050
* }
5151
* </code>
@@ -99,7 +99,7 @@
9999
* <pre>
100100
* <code>
101101
* try (JobServiceClient jobServiceClient = JobServiceClient.create()) {
102-
* JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
102+
* JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
103103
* jobServiceClient.deleteJob(name);
104104
* }
105105
* </code>

‎google-cloud-talent/src/test/java/com/google/cloud/talent/v4beta1/ApplicationServiceClientTest.java

+9-6
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ public void createApplicationTest() {
144144
ApplicationName.of("[PROJECT]", "[TENANT]", "[PROFILE]", "[APPLICATION]");
145145
String externalId = "externalId-1153075697";
146146
String profile = "profile-309425751";
147-
JobName job = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
148-
CompanyName company = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
147+
JobName job = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
148+
CompanyName company =
149+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
149150
String outcomeNotes = "outcomeNotes-355961964";
150151
String jobTitleSnippet = "jobTitleSnippet-1100512972";
151152
Application expectedResponse =
@@ -202,8 +203,9 @@ public void getApplicationTest() {
202203
ApplicationName.of("[PROJECT]", "[TENANT]", "[PROFILE]", "[APPLICATION]");
203204
String externalId = "externalId-1153075697";
204205
String profile = "profile-309425751";
205-
JobName job = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
206-
CompanyName company = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
206+
JobName job = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
207+
CompanyName company =
208+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
207209
String outcomeNotes = "outcomeNotes-355961964";
208210
String jobTitleSnippet = "jobTitleSnippet-1100512972";
209211
Application expectedResponse =
@@ -259,8 +261,9 @@ public void updateApplicationTest() {
259261
ApplicationName.of("[PROJECT]", "[TENANT]", "[PROFILE]", "[APPLICATION]");
260262
String externalId = "externalId-1153075697";
261263
String profile = "profile-309425751";
262-
JobName job = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
263-
CompanyName company = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
264+
JobName job = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
265+
CompanyName company =
266+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
264267
String outcomeNotes = "outcomeNotes-355961964";
265268
String jobTitleSnippet = "jobTitleSnippet-1100512972";
266269
Application expectedResponse =

‎google-cloud-talent/src/test/java/com/google/cloud/talent/v4beta1/CompanyServiceClientTest.java

+10-7
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public void deleteCompanyTest() {
104104
Empty expectedResponse = Empty.newBuilder().build();
105105
mockCompanyService.addResponse(expectedResponse);
106106

107-
CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
107+
CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
108108

109109
client.deleteCompany(name);
110110

@@ -126,7 +126,8 @@ public void deleteCompanyExceptionTest() throws Exception {
126126
mockCompanyService.addException(exception);
127127

128128
try {
129-
CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
129+
CompanyName name =
130+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
130131

131132
client.deleteCompany(name);
132133
Assert.fail("No exception raised");
@@ -138,7 +139,7 @@ public void deleteCompanyExceptionTest() throws Exception {
138139
@Test
139140
@SuppressWarnings("all")
140141
public void createCompanyTest() {
141-
CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
142+
CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
142143
String displayName = "displayName1615086568";
143144
String externalId = "externalId-1153075697";
144145
String headquartersAddress = "headquartersAddress-1879520036";
@@ -201,7 +202,8 @@ public void createCompanyExceptionTest() throws Exception {
201202
@Test
202203
@SuppressWarnings("all")
203204
public void getCompanyTest() {
204-
CompanyName name2 = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
205+
CompanyName name2 =
206+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
205207
String displayName = "displayName1615086568";
206208
String externalId = "externalId-1153075697";
207209
String headquartersAddress = "headquartersAddress-1879520036";
@@ -226,7 +228,7 @@ public void getCompanyTest() {
226228
.build();
227229
mockCompanyService.addResponse(expectedResponse);
228230

229-
CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
231+
CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
230232

231233
Company actualResponse = client.getCompany(name);
232234
Assert.assertEquals(expectedResponse, actualResponse);
@@ -249,7 +251,8 @@ public void getCompanyExceptionTest() throws Exception {
249251
mockCompanyService.addException(exception);
250252

251253
try {
252-
CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
254+
CompanyName name =
255+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
253256

254257
client.getCompany(name);
255258
Assert.fail("No exception raised");
@@ -261,7 +264,7 @@ public void getCompanyExceptionTest() throws Exception {
261264
@Test
262265
@SuppressWarnings("all")
263266
public void updateCompanyTest() {
264-
CompanyName name = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
267+
CompanyName name = CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
265268
String displayName = "displayName1615086568";
266269
String externalId = "externalId-1153075697";
267270
String headquartersAddress = "headquartersAddress-1879520036";

‎google-cloud-talent/src/test/java/com/google/cloud/talent/v4beta1/JobServiceClientTest.java

+13-10
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public void deleteJobTest() {
111111
Empty expectedResponse = Empty.newBuilder().build();
112112
mockJobService.addResponse(expectedResponse);
113113

114-
JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
114+
JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
115115

116116
client.deleteJob(name);
117117

@@ -133,7 +133,7 @@ public void deleteJobExceptionTest() throws Exception {
133133
mockJobService.addException(exception);
134134

135135
try {
136-
JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
136+
JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
137137

138138
client.deleteJob(name);
139139
Assert.fail("No exception raised");
@@ -145,8 +145,9 @@ public void deleteJobExceptionTest() throws Exception {
145145
@Test
146146
@SuppressWarnings("all")
147147
public void createJobTest() {
148-
JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
149-
CompanyName company = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
148+
JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
149+
CompanyName company =
150+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
150151
String requisitionId = "requisitionId980224926";
151152
String title = "title110371416";
152153
String description = "description-1724546052";
@@ -261,8 +262,9 @@ public void batchCreateJobsExceptionTest() throws Exception {
261262
@Test
262263
@SuppressWarnings("all")
263264
public void getJobTest() {
264-
JobName name2 = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
265-
CompanyName company = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
265+
JobName name2 = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
266+
CompanyName company =
267+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
266268
String requisitionId = "requisitionId980224926";
267269
String title = "title110371416";
268270
String description = "description-1724546052";
@@ -290,7 +292,7 @@ public void getJobTest() {
290292
.build();
291293
mockJobService.addResponse(expectedResponse);
292294

293-
JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
295+
JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
294296

295297
Job actualResponse = client.getJob(name);
296298
Assert.assertEquals(expectedResponse, actualResponse);
@@ -313,7 +315,7 @@ public void getJobExceptionTest() throws Exception {
313315
mockJobService.addException(exception);
314316

315317
try {
316-
JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
318+
JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
317319

318320
client.getJob(name);
319321
Assert.fail("No exception raised");
@@ -325,8 +327,9 @@ public void getJobExceptionTest() throws Exception {
325327
@Test
326328
@SuppressWarnings("all")
327329
public void updateJobTest() {
328-
JobName name = JobName.ofProjectJobName("[PROJECT]", "[JOB]");
329-
CompanyName company = CompanyName.ofProjectCompanyName("[PROJECT]", "[COMPANY]");
330+
JobName name = JobName.ofProjectTenantJobName("[PROJECT]", "[TENANT]", "[JOB]");
331+
CompanyName company =
332+
CompanyName.ofProjectTenantCompanyName("[PROJECT]", "[TENANT]", "[COMPANY]");
330333
String requisitionId = "requisitionId980224926";
331334
String title = "title110371416";
332335
String description = "description-1724546052";

0 commit comments

Comments
 (0)