Skip to content

Commit 3e02b9c

Browse files
authored
Revert "feat: expose all the methods of notification (#141)" (#393)
This reverts commit 8dfc0cb.
1 parent 8dfc0cb commit 3e02b9c

14 files changed

+1
-743
lines changed

google-cloud-storage/clirr-ignored-differences.xml

-25
Original file line numberDiff line numberDiff line change
@@ -26,29 +26,4 @@
2626
<method>com.google.cloud.storage.BucketInfo$Builder deleteLifecycleRules()</method>
2727
<differenceType>7013</differenceType>
2828
</difference>
29-
<difference>
30-
<className>com/google/cloud/storage/Storage</className>
31-
<method>com.google.api.services.storage.model.Notification createNotification(java.lang.String, com.google.cloud.storage.NotificationInfo)</method>
32-
<differenceType>7012</differenceType>
33-
</difference>
34-
<difference>
35-
<className>com/google/cloud/storage/Storage</className>
36-
<method>com.google.api.services.storage.model.Notification getNotification(java.lang.String, java.lang.String)</method>
37-
<differenceType>7012</differenceType>
38-
</difference>
39-
<difference>
40-
<className>com/google/cloud/storage/Storage</className>
41-
<method>java.util.List listNotifications(java.lang.String)</method>
42-
<differenceType>7012</differenceType>
43-
</difference>
44-
<difference>
45-
<className>com/google/cloud/storage/Storage</className>
46-
<method>boolean deleteNotification(java.lang.String, java.lang.String)</method>
47-
<differenceType>7012</differenceType>
48-
</difference>
49-
<difference>
50-
<className>com/google/cloud/storage/spi/v1/StorageRpc</className>
51-
<method>com.google.api.services.storage.model.Notification getNotification(java.lang.String, java.lang.String)</method>
52-
<differenceType>7012</differenceType>
53-
</difference>
5429
</differences>

google-cloud-storage/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,6 @@
155155
<artifactId>truth</artifactId>
156156
<scope>test</scope>
157157
</dependency>
158-
<dependency>
159-
<groupId>com.google.cloud</groupId>
160-
<artifactId>google-cloud-pubsub</artifactId>
161-
<scope>test</scope>
162-
</dependency>
163158
<dependency>
164159
<groupId>org.easymock</groupId>
165160
<artifactId>easymock</artifactId>

google-cloud-storage/src/main/java/com/google/cloud/storage/NotificationInfo.java

-309
This file was deleted.

google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

-33
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import com.google.api.core.InternalExtensionOnly;
2323
import com.google.api.gax.paging.Page;
24-
import com.google.api.services.storage.model.Notification;
2524
import com.google.auth.ServiceAccountSigner;
2625
import com.google.auth.ServiceAccountSigner.SigningException;
2726
import com.google.cloud.FieldSelector;
@@ -3434,36 +3433,4 @@ List<Boolean> testIamPermissions(
34343433
* @throws StorageException upon failure
34353434
*/
34363435
ServiceAccount getServiceAccount(String projectId);
3437-
3438-
/**
3439-
* Creates a notification with the specified entity on the specified bucket.
3440-
*
3441-
* @return the notification that was created.
3442-
* @throws StorageException upon failure
3443-
*/
3444-
Notification createNotification(String bucket, NotificationInfo notification);
3445-
3446-
/**
3447-
* Get the notification with the specified name on the specified object.
3448-
*
3449-
* @return the notification object that exist on the bucket.
3450-
* @throws StorageException upon failure
3451-
*/
3452-
Notification getNotification(String bucket, String notification);
3453-
3454-
/**
3455-
* List the notifications for the provided bucket.
3456-
*
3457-
* @return a list of {@link Notification} objects that exist on the bucket.
3458-
* @throws StorageException upon failure
3459-
*/
3460-
List<Notification> listNotifications(String bucket);
3461-
3462-
/**
3463-
* Deletes the notification with the specified name on the specified object.
3464-
*
3465-
* @return {@code true} if the notification was deleted, {@code false} if it was not found
3466-
* @throws StorageException upon failure
3467-
*/
3468-
boolean deleteNotification(String bucket, String notification);
34693436
}

0 commit comments

Comments
 (0)