Skip to content

Commit a60dc0c

Browse files
committed
review comments
1 parent bdd50ee commit a60dc0c

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -820,8 +820,8 @@ public static class Builder
820820
private OpenTelemetry openTelemetry;
821821
private boolean enableApiTracing = SpannerOptions.environment.isEnableApiTracing();
822822
private boolean enableExtendedTracing = SpannerOptions.environment.isEnableExtendedTracing();
823-
private boolean enableBuiltInMetrics = true;
824823
private boolean enableEndToEndTracing = SpannerOptions.environment.isEnableEndToEndTracing();
824+
private boolean enableBuiltInMetrics = true;
825825

826826
private static String createCustomClientLibToken(String token) {
827827
return token + " " + ServiceOptions.getGoogApiClientLibName();
@@ -1403,10 +1403,10 @@ public Builder setEnableApiTracing(boolean enableApiTracing) {
14031403
}
14041404

14051405
/**
1406-
* Sets whether to enable or disable built in metrics for Data client Operations. Built in
1407-
* metrics are enabled as default.
1406+
* Sets whether to enable or disable built in metrics for Data client operations. Built in
1407+
* metrics are enabled by default.
14081408
*/
1409-
public Builder setEnableBuiltInMetrics(boolean enableBuiltInMetrics) {
1409+
public Builder setBuiltInMetricsEnabled(boolean enableBuiltInMetrics) {
14101410
this.enableBuiltInMetrics = enableBuiltInMetrics;
14111411
return this;
14121412
}
@@ -1727,7 +1727,8 @@ private ApiTracerFactory createMetricsApiTracerFactory() {
17271727
? new MetricsTracerFactory(
17281728
new OpenTelemetryMetricsRecorder(openTelemetry, BuiltInMetricsConstant.METER_NAME),
17291729
builtInOpenTelemetryMetricsProvider.createClientAttributes(
1730-
this.getProjectId(), "spanner-java/" + GaxProperties.getLibraryVersion(getClass())))
1730+
this.getProjectId(),
1731+
"spanner-java/" + GaxProperties.getLibraryVersion(getClass())))
17311732
: null;
17321733
}
17331734

google-cloud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetryBuiltInMetricsTracerTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public void createSpannerInstance() {
148148
.build())
149149
// Setting this to false so that Spanner Options does not register Metrics Tracer
150150
// factory again.
151-
.setEnableBuiltInMetrics(false)
151+
.setBuiltInMetricsEnabled(false)
152152
.setApiTracerFactory(metricsTracerFactory)
153153
.build()
154154
.getService();

0 commit comments

Comments
 (0)