Skip to content

Commit 94fd5bb

Browse files
committed
fix: uses old version of gax-grpc method
Internally, we are using version 1.47.1 of the gax-grpc library, which does not provide a method currently being used (setExecutor). In here we use a method that is available in 1.47.1 and achieves the same goal (setExecutorProvider).
1 parent b312091 commit 94fd5bb

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
import com.google.cloud.spanner.admin.instance.v1.stub.GrpcInstanceAdminStub;
6161
import com.google.cloud.spanner.admin.instance.v1.stub.InstanceAdminStub;
6262
import com.google.cloud.spanner.admin.instance.v1.stub.InstanceAdminStubSettings;
63-
import com.google.cloud.spanner.spi.v1.SpannerRpc.Option;
6463
import com.google.cloud.spanner.v1.stub.GrpcSpannerStub;
6564
import com.google.cloud.spanner.v1.stub.SpannerStub;
6665
import com.google.cloud.spanner.v1.stub.SpannerStubSettings;
@@ -317,7 +316,11 @@ public GapicSpannerRpc(final SpannerOptions options) {
317316
.setMaxInboundMessageSize(MAX_MESSAGE_SIZE)
318317
.setMaxInboundMetadataSize(MAX_METADATA_SIZE)
319318
.setPoolSize(options.getNumChannels())
320-
.setExecutor(executorProvider.getExecutor())
319+
320+
// Before updating this method to setExecutor, please make sure to verify the version
321+
// of gax-grpc used internally. At the moment we are using 1.47.1, which does not
322+
// support the setExecutor variant.
323+
.setExecutorProvider(executorProvider)
321324

322325
// Set a keepalive time of 120 seconds to help long running
323326
// commit GRPC calls succeed

0 commit comments

Comments
 (0)