Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

feat!: Removing TimeSeriesQueryLanguageCondition as an alert condition type #161

Merged
merged 9 commits into from
Jun 5, 2020
Merged

feat!: Removing TimeSeriesQueryLanguageCondition as an alert condition type #161

merged 9 commits into from
Jun 5, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented May 9, 2020 •
edited by chingor13
Loading

The condition type is unsupported and unused. It was originally added for the Monitoring Query Language Alpha feature.

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/ceea7185-8991-4321-ac64-03d9792fe72a/targets

PiperOrigin-RevId: 310060413
Source-Link: googleapis/googleapis@a3a0bf0

BREAKING_CHANGE: TimeSeriesQueryLanguageCondition has been removed.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2020
@yoshi-automation yoshi-automation force-pushed the autosynth branch 7 times, most recently from a03b8a2 to 6e06ae7 Compare May 13, 2020 10:00
@codecov
Copy link

codecov bot commented May 13, 2020 •
edited
Loading

Codecov Report

Merging #161 into master will decrease coverage by 0.23%.
The diff coverage is 78.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #161      +/-   ##
============================================
- Coverage     73.90%   73.66%   -0.24%     
  Complexity      422      422              
============================================
  Files            36       36              
  Lines          3384     3395      +11     
  Branches         47       49       +2     
============================================
  Hits           2501     2501              
- Misses          822      831       +9     
- Partials         61       63       +2
Impacted Files Coverage Δ Complexity Δ
...onitoring/v3/ServiceMonitoringServiceSettings.java 13.46% <0.00%> (ø) 2.00 <0.00> (ø)
...nitoring/v3/stub/ServiceMonitoringServiceStub.java 7.69% <0.00%> (ø) 1.00 <0.00> (ø)
.../monitoring/v3/ServiceMonitoringServiceClient.java 64.05% <56.52%> (ø) 42.00 <8.00> (ø)
.../v3/stub/ServiceMonitoringServiceStubSettings.java 79.22% <85.00%> (ø) 20.00 <2.00> (ø)
...ring/v3/stub/GrpcServiceMonitoringServiceStub.java 95.43% <100.00%> (ø) 17.00 <4.00> (ø)
.../cloud/monitoring/v3/UptimeCheckServiceClient.java 65.17% <0.00%> (-7.10%) 25.00% <0.00%> (ø%)
...google/cloud/monitoring/v3/GroupServiceClient.java 61.53% <0.00%> (ø) 26.00% <0.00%> (ø%)
...oogle/cloud/monitoring/v3/MetricServiceClient.java 64.20% <0.00%> (ø) 35.00% <0.00%> (ø%)
...ogle/cloud/monitoring/v3/GroupServiceSettings.java 17.94% <0.00%> (ø) 2.00% <0.00%> (ø%)
.../cloud/monitoring/v3/AlertPolicyServiceClient.java 63.21% <0.00%> (ø) 23.00% <0.00%> (ø%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed9f56...0e00b24. Read the comment docs.

@yoshi-automation yoshi-automation force-pushed the autosynth branch 4 times, most recently from f87d721 to 203f3b0 Compare May 15, 2020 02:26
@yoshi-automation
Integrate Python GAPIC Microgenerator in googleapis.
3aa088c 
This PR uses using documentai as an example.
Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
@yoshi-automation
BREAKING_CHANGE: Removing TimeSeriesQueryLanguageCondition as an aler…
d7f5ef1 
…t condition type. The condition type is unsupported and unused. It was originally added for the Monitoring Query Language Alpha feature.

refactor!: Drop support for TimeSeriesQueryLanguageCondition as an alert condition type.

PiperOrigin-RevId: 310060413

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 5 18:17:54 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: a3a0bf0f6291d69f2ff3df7fcd63d28ee20ac727
Source-Link: googleapis/googleapis@a3a0bf0
@yoshi-automation
ci(java): switch to GitHub Actions (#533)
2799c84 
* ci: switch to GitHub Actions

* update based on comment

Source-Author: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Source-Date: Mon May 11 12:54:00 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 55cdc844877d97139f25004229842624a6a86a02
Source-Link: googleapis/synthtool@55cdc84
@yoshi-automation
chore: move ci.yaml to workflows dir (#535)
bbee702 
Source-Author: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Source-Date: Mon May 11 16:24:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 98c50772ec23295c64cf0d2ddf199ea52961fd4c
Source-Link: googleapis/synthtool@98c5077
@yoshi-automation
docs: update CONTRIBUTING.md to include code formatting (#534)
5ad0c45 
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Brian Chen <chenbrian@google.com>
Source-Date: Tue May 12 10:24:59 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5b48b0716a36ca069db3038da7e205c87a22ed19
Source-Link: googleapis/synthtool@5b48b07
@yoshi-automation
chore!: enable gapicv2 for monitoring/v3 API
254c057 
This introduces the following breakages upon code regeneration, which are due to the `TimeSeriesQueryLanguageCondition` type being removed from `alert.proto` in a preceding change.

```
[ERROR] 6011: com.google.monitoring.v3.AlertPolicy$Condition: Field CONDITION_TIME_SERIES_QUERY_LANGUAGE_FIELD_NUMBER has been removed, but it was previously a constant
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder clearConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder getConditionTimeSeriesQueryLanguageBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder mergeConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder)' has been removed
[ERROR] 6001: com.google.monitoring.v3.AlertPolicy$Condition$ConditionCase: Removed field CONDITION_TIME_SERIES_QUERY_LANGUAGE
[ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition removed
[ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder removed
[ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed
```

Committer: @miraleung
PiperOrigin-RevId: 311581003

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 14 12:13:51 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 123873dc7e2be35252d172205f67a375e70e9747
Source-Link: googleapis/googleapis@123873d
@chingor13 chingor13 closed this Jun 5, 2020
@chingor13 chingor13 reopened this Jun 5, 2020
@chingor13 chingor13 changed the title BREAKING_CHANGE: Removing TimeSeriesQueryLanguageCondition as an alert condition type. The condition type is unsupported and unused. It was originally added for the Monitoring Query Language Alpha feature. feat!: Removing TimeSeriesQueryLanguageCondition as an alert condition typeIt was originally added for the Monitoring Query Language Alpha feature. Jun 5, 2020
@chingor13 chingor13 changed the title feat!: Removing TimeSeriesQueryLanguageCondition as an alert condition typeIt was originally added for the Monitoring Query Language Alpha feature. feat!: Removing TimeSeriesQueryLanguageCondition as an alert condition type Jun 5, 2020
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit da7e3b9 into master Jun 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth branch June 5, 2020 21:56
@release-please release-please bot mentioned this pull request Jun 5, 2020
Merged
@grant grant mentioned this pull request Nov 13, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshi-automation @chingor13 @googlebot