Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Commit db345f4

Browse files
authored
tests: clean up tests for IAM condition support (#224)
* tests: clean up tests for IAM condition support * tests: clean up tests for IAM condition support * feat: addressed review changes
1 parent ed4d672 commit db345f4

File tree

1 file changed

+17
-20
lines changed

1 file changed

+17
-20
lines changed

google-cloud-core/src/test/java/com/google/cloud/PolicyV3Test.java

+17-20
Original file line numberDiff line numberDiff line change
@@ -42,28 +42,25 @@ public class PolicyV3Test {
4242
private static final String VIEWER = "roles/viewer";
4343
private static final String EDITOR = "roles/editor";
4444
private static final String OWNER = "roles/owner";
45-
private static final List<String> MEMBERS_LIST_1 =
45+
private static final ImmutableList<String> MEMBERS_LIST_1 =
4646
ImmutableList.of(USER, SERVICE_ACCOUNT, ALL_USERS);
47-
private static final List<String> MEMBERS_LIST_2 =
47+
private static final ImmutableList<String> MEMBERS_LIST_2 =
4848
ImmutableList.of(ALL_AUTH_USERS, GROUP, DOMAIN);
49-
private static final List<Binding> BINDINGS_NO_CONDITIONS =
50-
ImmutableList.of(
51-
Binding.newBuilder().setRole(VIEWER).setMembers(MEMBERS_LIST_1).build(),
52-
Binding.newBuilder().setRole(EDITOR).setMembers(MEMBERS_LIST_2).build());
53-
private static final List<Binding> BINDINGS_WITH_CONDITIONS =
54-
ImmutableList.copyOf(BINDINGS_NO_CONDITIONS)
55-
.of(
56-
Binding.newBuilder()
57-
.setRole(VIEWER)
58-
.setMembers(MEMBERS_LIST_1)
59-
.setCondition(
60-
Condition.newBuilder()
61-
.setTitle("Condition")
62-
.setDescription("Condition")
63-
.setExpression("Expr")
64-
.build())
65-
.build(),
66-
Binding.newBuilder().setRole(EDITOR).setMembers(MEMBERS_LIST_2).build());
49+
50+
private static final Binding VIEWER_BINDING =
51+
Binding.newBuilder().setRole(VIEWER).setMembers(MEMBERS_LIST_1).build();
52+
private static final Binding EDITOR_BINDING =
53+
Binding.newBuilder().setRole(EDITOR).setMembers(MEMBERS_LIST_2).build();
54+
private static final ImmutableList<Binding> BINDINGS_NO_CONDITIONS =
55+
ImmutableList.of(VIEWER_BINDING, EDITOR_BINDING);
56+
private static final Condition CONDITION =
57+
Condition.newBuilder()
58+
.setTitle("Condition")
59+
.setDescription("Condition")
60+
.setExpression("Expr")
61+
.build();
62+
private static final ImmutableList<Binding> BINDINGS_WITH_CONDITIONS =
63+
ImmutableList.of(VIEWER_BINDING.toBuilder().setCondition(CONDITION).build(), EDITOR_BINDING);
6764
private static final Policy FULL_POLICY_V1 =
6865
Policy.newBuilder().setBindings(BINDINGS_NO_CONDITIONS).setEtag("etag").setVersion(1).build();
6966

0 commit comments

Comments
 (0)