Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: two-way replication for Hbase-Bigtable replication #3920

Merged
merged 34 commits into from
Jun 14, 2023
Merged

feat: two-way replication for Hbase-Bigtable replication #3920

merged 34 commits into from
Jun 14, 2023

Conversation

georgecma
Copy link
Contributor

@georgecma georgecma commented Jan 17, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3935 ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Jan 17, 2023
@vermas2012 vermas2012 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@vermas2012
Copy link
Member

Is it ready for review ?

@georgecma georgecma changed the title Two-way replication for Hbase-Bigtable replication feat: two-way replication for Hbase-Bigtable replication Jan 24, 2023
@georgecma georgecma marked this pull request as ready for review January 24, 2023 00:56
@georgecma georgecma requested a review from a team as a code owner January 24, 2023 00:56
@vermas2012 vermas2012 self-assigned this Jan 24, 2023
@vermas2012 vermas2012 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2023
@georgecma georgecma mentioned this pull request Jan 24, 2023
Open
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2023
@vermas2012
Copy link
Member

vermas2012 commented Feb 13, 2023 •
edited
Loading

Looks good to me, Lets get Igor to review it and then he can merge it.

@georgecma georgecma mentioned this pull request Mar 16, 2023
Merged
3 tasks
@georgecma georgecma changed the title feat: two-way replication for Hbase-Bigtable replication Overload HbaseIO with KV<RowKey, RowMutations> Mar 16, 2023
@georgecma georgecma changed the title Overload HbaseIO with KV<RowKey, RowMutations> feat: two-way replication for Hbase-Bigtable replication Mar 16, 2023
igorbernstein2
igorbernstein2 requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the README giving endusers an idea as to what this feature does and how to use it

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jun 12, 2023
@georgecma georgecma requested a review from igorbernstein2 June 12, 2023 13:59
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2023
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0d75465 into googleapis:main Jun 14, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2023
@release-please release-please bot mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@vermas2012 vermas2012 vermas2012 approved these changes

Assignees

@vermas2012 vermas2012

Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@georgecma @vermas2012 @igorbernstein2 @yoshi-kokoro @kolea2