feat: flag future deletes and record a metrics #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
sushanb
changed the title
vermas2012
requested changes
Mar 2, 2022
| @@ -109,6 +114,10 @@ private boolean isValidDelete(Cell delete) { | |||
|
|
|||
| // Compatible delete | |||
| if (isValidDelete(cell)) { | |||
| // flag if delete was issued in future | |||
| if (cell.getTimestamp() > walEntry.getWalWriteTime()) { | |||
There was a problem hiding this comment.
Why is this incompatible? Please update as per our discussions yesterday.
vermas2012
requested changes
Mar 9, 2022
...n/java/com/google/cloud/bigtable/hbase/replication/adapters/IncompatibleMutationAdapter.java
Outdated
Show resolved
Hide resolved
| @@ -24,4 +24,5 @@ private HBaseToCloudBigtableReplicationMetrics() {} | |||
| public static final String INCOMPATIBLE_MUTATION_METRIC_KEY = "bigtableIncompatibleMutations"; | |||
| public static final String DROPPED_INCOMPATIBLE_MUTATION_METRIC_KEY = | |||
| "bigtableDroppedIncompatibleMutations"; | |||
| public static final String FUTURE_DELETE_MUTATION_METRIC_KEY = "bigtableFutureDeleteMutations"; | |||
There was a problem hiding this comment.
There is no delete happening "yet". The name should be bigtablePutsInFuture or something like that.
vermas2012
approved these changes
Mar 14, 2022
vermas2012
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.0...v2.1.0) (2022-04-01) ### Features * [hase-cbt-replication]Add a metrics for hbase<>bigtable timestamp overflow ([#3540](#3540)) ([9c73318](9c73318)) * Adding a detailed readme for HBase replication support. ([#3527](#3527)) ([b406ac5](b406ac5)) * enable dry-run mode for HBase to Cloud Bigtable replication ([#3532](#3532)) ([164738b](164738b)) * Enable HBase to Cloud Bigtable replication ([#3510](#3510)) ([68d4a01](68d4a01)) * flag a put in future timestamp and record a metrics ([#3534](#3534)) ([7dd7653](7dd7653)) * remove base repl endpoint from hbase 2.x ([#3539](#3539)) ([f748c70](f748c70)) ### Bug Fixes * [hbase-cbt-replication] make hbase2.x endpoint context private ([#3559](#3559)) ([5ec3b18](5ec3b18)) * consistent behavior of customwalentry filter across hbase1.x and hbase2.x ([#3562](#3562)) ([f70b0cb](f70b0cb)) * license and notice files for all the shaded artifacts ([#3565](#3565)) ([86a5643](86a5643)) * minor documentation update ([#3572](#3572)) ([68db6c2](68db6c2)) ### Documentation * fix typos in README and add --region option ([#3520](#3520)) ([c189d46](c189d46)) ### Dependencies * update dependency ch.qos.logback:logback-classic to v1.2.11 ([#3538](#3538)) ([92e8b63](92e8b63)) * update dependency com.google.cloud:google-cloud-bigtable-emulator to v0.142.3 ([#3528](#3528)) ([33a8eba](33a8eba)) * update dependency com.google.cloud:google-cloud-bigtable-emulator to v0.143.0 ([#3543](#3543)) ([2d57f14](2d57f14)) * update dependency net.bytebuddy:byte-buddy to v1.12.8 ([#3502](#3502)) ([77ae2f1](77ae2f1)) * update jmh.version to v1.35 ([#3561](#3561)) ([188738d](188738d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per conversation on #3521
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️