fix: clean up timeout defaults and drop the ability to disable timeouts #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
mutianf
reviewed
Dec 3, 2021
...c/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/BigtableHBaseVeneerSettings.java
Show resolved
Hide resolved
...c/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/BigtableHBaseVeneerSettings.java
Show resolved
Hide resolved
| Optional.of(Duration.ofMinutes(5)), | ||
| Optional.of(Duration.ofMinutes(10)), | ||
| Optional.absent()), | ||
| /* bulkMutateTimeouts = */ new OperationTimeouts( |
There was a problem hiding this comment.
should be /* bulkTimeouts = */ right? I think we decided for bulk read and bulk mutate to both have attempt 1m, and op 10m?
There was a problem hiding this comment.
This is less than ideal, for now we use scan timeouts for bulk reads. Ideally we would have a separate bulk read time outs. Unfortunately the current naming makes this difficult. For the time being, I'm going to punt on this until a future moment that we can clean up the settings
mutianf
reviewed
Dec 23, 2021
...c/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/BigtableHBaseVeneerSettings.java
Show resolved
Hide resolved
mutianf
reviewed
Dec 23, 2021
...rent/bigtable-hbase-1.x/src/test/java/com/google/cloud/bigtable/hbase/TestRetryBehavior.java
Outdated
Show resolved
Hide resolved
...rent/bigtable-hbase-1.x/src/test/java/com/google/cloud/bigtable/hbase/TestRetryBehavior.java
Show resolved
Hide resolved
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
mutianf
approved these changes
Feb 10, 2022
igorbernstein2
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to clean up timeout handling. Previously bigtable-hbase ran in a "timeouts disabled mode" by default. This was a bit weird as it didnt actually disable timeouts. It just stopped reading user set timeouts and forced 6 min deadlines on non-scans.
This PR starts ignoring the
google.bigtable.rpc.use.timeoutsaltogether and updates the default timeouts to: