deps: migrate to log4j-core #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
vermas2012
reviewed
Nov 15, 2021
vermas2012
approved these changes
Nov 15, 2021
Thanks @vermas2012 for taking a look! I tried some testing and realized I had to make a few additional fixes. I was able to successfully get this to work by running the unit tests with the log4j2.xml file uncommented. I did change this to STDOUT as the output - is this ok? |
|
STDout is fine. I wonder if we should test logging by running the actual tool? |
You don't have to setup HBase, you can use this json file as a source for schema |
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
kolea2
added a commit
to kolea2/cloud-bigtable-client
that referenced
this pull request
Dec 10, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.26.0](https://github.com/googleapis/java-bigtable-hbase/compare/v1.25.1...v1.26.0) (2021-12-10) ### Features * bump next 1.x release to 1.26.0 ([#3327](https://github.com/googleapis/java-bigtable-hbase/issues/3327)) ([7da8fc2](https://github.com/googleapis/java-bigtable-hbase/commit/7da8fc24b29c0b9f01eda960630018421e2b1ee9)) ### Dependencies * migrate to log4j-core ([#3326](https://github.com/googleapis/java-bigtable-hbase/issues/3326)) ([#3375](https://github.com/googleapis/java-bigtable-hbase/issues/3375)) ([9142f13](https://github.com/googleapis/java-bigtable-hbase/commit/9142f1341f4542c8a48976cc3cf4675f76fe05db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mutianf
pushed a commit
to mutianf/java-bigtable-hbase
that referenced
this pull request
Sep 20, 2022
cherry pick of googleapis#3328 with upgrade to 2.15.0
mutianf
pushed a commit
to mutianf/java-bigtable-hbase
that referenced
this pull request
Sep 20, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.26.0](https://github.com/googleapis/java-bigtable-hbase/compare/v1.25.1...v1.26.0) (2021-12-10) ### Features * bump next 1.x release to 1.26.0 ([googleapis#3327](https://github.com/googleapis/java-bigtable-hbase/issues/3327)) ([7da8fc2](https://github.com/googleapis/java-bigtable-hbase/commit/7da8fc24b29c0b9f01eda960630018421e2b1ee9)) ### Dependencies * migrate to log4j-core ([googleapis#3326](https://github.com/googleapis/java-bigtable-hbase/issues/3326)) ([googleapis#3375](https://github.com/googleapis/java-bigtable-hbase/issues/3375)) ([9142f13](https://github.com/googleapis/java-bigtable-hbase/commit/9142f1341f4542c8a48976cc3cf4675f76fe05db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.