Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update readRowsAsync to use RetryingReadRowsOperation #2759

Merged

Conversation

igorbernstein2
Copy link
Collaborator

@igorbernstein2 igorbernstein2 commented Dec 11, 2020

This will allow that method to inherit features like stream resumption and retry on stream timeouts.

cherry pick of #2738

…s#2738)

* fix: update readRowsAsync to use RetryingReadRowsOperation

This will allow that method to inherit features like stream resumption and retry on stream timeouts.

* more tests

* comments
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner December 11, 2020 16:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Dec 11, 2020
@igorbernstein2 igorbernstein2 changed the title fix: update readRowsAsync to use RetryingReadRowsOperation (#2738) fix: update readRowsAsync to use RetryingReadRowsOperation (#2738) (master) Dec 11, 2020
@igorbernstein2 igorbernstein2 changed the title fix: update readRowsAsync to use RetryingReadRowsOperation (#2738) (master) fix: update readRowsAsync to use RetryingReadRowsOperation (master) Dec 11, 2020
@kolea2 kolea2 changed the title fix: update readRowsAsync to use RetryingReadRowsOperation (master) fix: update readRowsAsync to use RetryingReadRowsOperation Dec 11, 2020
@igorbernstein2 igorbernstein2 merged commit 3c4f3b2 into googleapis:master Dec 11, 2020
@igorbernstein2 igorbernstein2 deleted the watchdog-timeout-master branch December 11, 2020 19:49
lichng pushed a commit to lichng/java-bigtable-hbase that referenced this pull request Dec 29, 2020
…s#2738) (googleapis#2759)

* fix: update readRowsAsync to use RetryingReadRowsOperation

This will allow that method to inherit features like stream resumption and retry on stream timeouts.

* more tests

* comments
vermas2012 pushed a commit to vermas2012/java-bigtable-hbase that referenced this pull request Jan 1, 2021
…s#2738) (googleapis#2759)

* fix: update readRowsAsync to use RetryingReadRowsOperation

This will allow that method to inherit features like stream resumption and retry on stream timeouts.

* more tests

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants