Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to fix deleteRowRangeByPrefix for integer values above 127 #2511

Merged
merged 2 commits into from
May 11, 2020

Conversation

rahulKQL
Copy link
Contributor

Fixes: #2509

This commit removes the intermediate conversion of rowKeyPrefix with UTF-8 String. Now we directly convert user-provided byte array to ByteString protobuf.

Fixes: googleapis#2509

This commit removes the intermediate conversion of `rowKeyPrefix` with UTF-8 String. Now we directly converts user provided byte array to `ByteString` protobuf.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2020
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #2511 into master will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2511      +/-   ##
============================================
- Coverage     62.35%   62.34%   -0.01%     
- Complexity     1634     1636       +2     
============================================
  Files           200      200              
  Lines         10123    10129       +6     
  Branches       1035     1035              
============================================
+ Hits           6312     6315       +3     
- Misses         3348     3351       +3     
  Partials        463      463              
Impacted Files Coverage Δ Complexity Δ
...oud/bigtable/grpc/BigtableTableAdminGCJClient.java 83.33% <0.00%> (-7.58%) 20.00 <0.00> (ø)
...le/hbase/wrappers/veneer/AdminClientVeneerApi.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...che/hadoop/hbase/client/AbstractBigtableAdmin.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bigtable/grpc/BigtableTableAdminClientWrapper.java 100.00% <100.00%> (ø) 23.00 <2.00> (+2.00)
.../hbase/wrappers/classic/AdminClientClassicApi.java 100.00% <100.00%> (ø) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59cbe5...a8654a5. Read the comment docs.

Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2020
@rahulKQL rahulKQL merged commit 1ae8c03 into googleapis:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleteRowRangeByPrefix does not work for integer keys above 127
5 participants