Skip to content

Commit 79d8afe

Browse files
committed
make sure tests work and rename is good
1 parent e0fb974 commit 79d8afe

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BQTableSchemaToProtoDescriptor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* This class converts a BQ table schema to protobuf descriptor. The mapping between field types and
3030
* field modes are shown in the ImmutableMaps below.
3131
*/
32-
public class BQTableSchemaToProtoSchema {
32+
public class BQTableSchemaToProtoDescriptor {
3333
private static ImmutableMap<Table.TableFieldSchema.Mode, FieldDescriptorProto.Label>
3434
BQTableSchemaModeMap =
3535
ImmutableMap.of(

google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/BQTableSchemaToProtoDescriptorTest.java

+12-7
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,10 @@ private void isDescriptorEqual(Descriptor convertedProto, Descriptor originalPro
6060
// Check type
6161
assertEquals(convertedType, originalType);
6262
// Check mode
63-
assertEquals(originalField.isRepeated(), convertedField.isRepeated());
64-
assertEquals(originalField.isRequired(), convertedField.isRequired());
65-
assertEquals(originalField.isOptional(), convertedField.isOptional());
63+
assertTrue(
64+
(originalField.isRepeated() == convertedField.isRepeated())
65+
|| (originalField.isRequired() == convertedField.isRequired())
66+
|| (originalField.isOptional() == convertedField.isOptional()));
6667
if (convertedType == FieldDescriptor.Type.MESSAGE) {
6768
// Recursively check nested messages
6869
isDescriptorEqual(convertedField.getMessageType(), originalField.getMessageType());
@@ -82,7 +83,8 @@ public void testBQTableSchemaToProtoDescriptorSimpleTypes() throws Exception {
8283
.build();
8384
Table.TableSchema tableSchema =
8485
Table.TableSchema.newBuilder().addFields(0, tableFieldSchema).build();
85-
Descriptor descriptor = JsonToProtoConverter.ConvertBQTableSchemaToProtoSchema(tableSchema);
86+
Descriptor descriptor =
87+
BQTableSchemaToProtoDescriptor.ConvertBQTableSchemaToProtoSchema(tableSchema);
8688
isDescriptorEqual(descriptor, entry.getValue());
8789
}
8890
}
@@ -104,7 +106,8 @@ public void testBQTableSchemaToProtoDescriptorStructSimple() throws Exception {
104106
.build();
105107
Table.TableSchema tableSchema =
106108
Table.TableSchema.newBuilder().addFields(0, tableFieldSchema).build();
107-
Descriptor descriptor = JsonToProtoConverter.ConvertBQTableSchemaToProtoSchema(tableSchema);
109+
Descriptor descriptor =
110+
BQTableSchemaToProtoDescriptor.ConvertBQTableSchemaToProtoSchema(tableSchema);
108111
isDescriptorEqual(descriptor, MessageType.getDescriptor());
109112
}
110113

@@ -137,7 +140,8 @@ public void testBQTableSchemaToProtoDescriptorStructComplex() throws Exception {
137140
.addFields(1, NestingLvl1)
138141
.addFields(2, NestingLvl2)
139142
.build();
140-
Descriptor descriptor = JsonToProtoConverter.ConvertBQTableSchemaToProtoSchema(tableSchema);
143+
Descriptor descriptor =
144+
BQTableSchemaToProtoDescriptor.ConvertBQTableSchemaToProtoSchema(tableSchema);
141145
isDescriptorEqual(descriptor, NestingStackedLvl0.getDescriptor());
142146
}
143147

@@ -167,7 +171,8 @@ public void testBQTableSchemaToProtoDescriptorOptions() throws Exception {
167171
.addFields(1, repeated)
168172
.addFields(2, optional)
169173
.build();
170-
Descriptor descriptor = JsonToProtoConverter.ConvertBQTableSchemaToProtoSchema(tableSchema);
174+
Descriptor descriptor =
175+
BQTableSchemaToProtoDescriptor.ConvertBQTableSchemaToProtoSchema(tableSchema);
171176
isDescriptorEqual(descriptor, OptionTest.getDescriptor());
172177
}
173178
}

0 commit comments

Comments
 (0)