-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw jobexception for invalid multiple statements query #732
Conversation
add another test case add exception checking Job class update reload() method
c91ddd3
to
946de7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
============================================
+ Coverage 81.07% 81.15% +0.08%
- Complexity 1236 1240 +4
============================================
Files 78 78
Lines 6334 6341 +7
Branches 705 708 +3
============================================
+ Hits 5135 5146 +11
+ Misses 833 828 -5
- Partials 366 367 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand on what's going on here in the PR description? I see you're adding a new raise to the reload, is this to match behavior from something else?
Indeed! Customer noticed that we are throwing Exception in invalid single-statement scenario but not invalid Multi-statement scenario. We are trying to make the behavior consistent here. |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.118.0](https://github.com/googleapis/java-bigquery/compare/v1.117.2...v1.118.0) (2020-09-17) ### Features * **bigquery:** explicitly ask for dense responses from HTTP backend ([#739](https://github.com/googleapis/java-bigquery/issues/739)) ([8c92c99](https://github.com/googleapis/java-bigquery/commit/8c92c9919b278bdb128be963391fc1870e69e343)) ### Bug Fixes * throw jobexception for invalid multiple statements query ([#732](https://github.com/googleapis/java-bigquery/issues/732)) ([2a0d86d](https://github.com/googleapis/java-bigquery/commit/2a0d86d2d07dd706fb7d943da6ebd5c9ac98dfca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Fixes b/163347694