This repository was archived by the owner on Sep 9, 2023. It is now read-only.
feat: add encryption_spec to aiplatform v1beta1 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committer: @miraleung PiperOrigin-RevId: 350067652 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon Jan 4 19:45:21 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: ad3bb00ed7750cd0625b3a36e0e2eff29f778e4a Source-Link: googleapis/googleapis@ad3bb00
Committer: @miraleung PiperOrigin-RevId: 350067652 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon Jan 4 19:45:21 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: ad3bb00ed7750cd0625b3a36e0e2eff29f778e4a Source-Link: googleapis/googleapis@ad3bb00
Committer: @miraleung PiperOrigin-RevId: 350949863 Source-Author: Google APIs <noreply@google.com> Source-Date: Sat Jan 9 14:01:49 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: 91e206bcfeaf8948ea03fe3cb1b7616108496cd3 Source-Link: googleapis/googleapis@91e206b
PiperOrigin-RevId: 354148500 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Jan 27 12:35:58 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: d99d5d592f3d1d5526511c90120b1e9ab3ce6e17 Source-Link: googleapis/googleapis@d99d5d5
google-cla
bot
added
the
cla: yes
Neenu1995
changed the title
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=========================================
Coverage 78.23% 78.23%
Complexity 707 707
=========================================
Files 49 49
Lines 5133 5133
Branches 69 69
=========================================
Hits 4016 4016
Misses 1028 1028
Partials 89 89
Continue to review full report at Codecov.
|
|
An example to address these errors More info: https://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html Test locally by running |
Neenu1995
approved these changes
Feb 16, 2021
chingor13
changed the title
chingor13
reviewed
Feb 18, 2021
Comment on lines
+5
to
+19
| <difference> | ||
| <className> | ||
| com/google/cloud/aiplatform/v1beta1/BatchMigrateResourcesOperationMetadataOrBuilder | ||
| </className> | ||
| <differenceType>7012</differenceType> | ||
| <method>* getPartialResults(*)</method> | ||
| </difference> | ||
|
|
||
| <difference> | ||
| <className> | ||
| com/google/cloud/aiplatform/v1beta1/BatchMigrateResourcesOperationMetadataOrBuilder | ||
| </className> | ||
| <differenceType>7012</differenceType> | ||
| <method>* getPartialResultsCount()</method> | ||
| </difference> |
There was a problem hiding this comment.
Generally, for the protos, we use a wildcard matcher for these. Example: https://github.com/googleapis/java-asset/blob/911e403a2d149f24a40bc7c99021777542ab6a8a/proto-google-cloud-asset-v1/clirr-ignored-differences.xml#L4-L18
telpirion
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/b54f7bec-a892-42f3-a548-6aa9abc95c37/targets
PiperOrigin-RevId: 354148500
Source-Link: googleapis/googleapis@d99d5d5
PiperOrigin-RevId: 350949863
Source-Link: googleapis/googleapis@91e206b
PiperOrigin-RevId: 350067652
Source-Link: googleapis/googleapis@ad3bb00