From 543caafeca36e44d59402c4d738277de35e510fe Mon Sep 17 00:00:00 2001 From: Tres Seaver Date: Wed, 14 Oct 2015 16:49:40 -0400 Subject: [PATCH] Add system test exercising 'Subscription.create' w/ 'ack_deadline' set. Addresses: https://github.com/GoogleCloudPlatform/gcloud-python/pull/1182#issuecomment-148179326 --- system_tests/pubsub.py | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/system_tests/pubsub.py b/system_tests/pubsub.py index 506d17722ca3..d4eefb60eb79 100644 --- a/system_tests/pubsub.py +++ b/system_tests/pubsub.py @@ -61,7 +61,7 @@ def test_list_topics(self): topic.project == CLIENT.project] self.assertEqual(len(created), len(topics_to_create)) - def test_create_subscription(self): + def test_create_subscription_defaults(self): TOPIC_NAME = 'subscribe-me' topic = CLIENT.topic(TOPIC_NAME) self.assertFalse(topic.exists()) @@ -76,6 +76,22 @@ def test_create_subscription(self): self.assertEqual(subscription.name, SUBSCRIPTION_NAME) self.assertTrue(subscription.topic is topic) + def test_create_subscription_w_ack_deadline(self): + TOPIC_NAME = 'subscribe-me' + topic = CLIENT.topic(TOPIC_NAME) + self.assertFalse(topic.exists()) + topic.create() + self.to_delete.append(topic) + SUBSCRIPTION_NAME = 'subscribing-now' + subscription = topic.subscription(SUBSCRIPTION_NAME, ack_deadline=120) + self.assertFalse(subscription.exists()) + subscription.create() + self.to_delete.append(subscription) + self.assertTrue(subscription.exists()) + self.assertEqual(subscription.name, SUBSCRIPTION_NAME) + self.assertEqual(subscription.ack_deadline, 120) + self.assertTrue(subscription.topic is topic) + def test_list_subscriptions(self): TOPIC_NAME = 'subscribe-me' topic = CLIENT.topic(TOPIC_NAME)