Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_default always sets credentials.quota_project_id to None #559

Closed
busunkim96 opened this issue Jul 15, 2020 · 0 comments · Fixed by #560
Closed

_default always sets credentials.quota_project_id to None #559

busunkim96 opened this issue Jul 15, 2020 · 0 comments · Fixed by #560
Assignees
@busunkim96
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Jul 15, 2020 •
edited
Loading

#546 introduced a bug where the quota project id always gets set to None. If no quota_project_id is passed to load_credentials_from_file(...) or default(...), the existing project should not be overridden
@busunkim96 busunkim96 self-assigned this Jul 15, 2020
@busunkim96 busunkim96 mentioned this issue Jul 15, 2020
Merged
@busunkim96 busunkim96 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't add empty quota project googleapis/google-auth-library-python
1 participant
@busunkim96