fix: ensures GCE metadata sets email field for ID tokens #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 19 19
Lines 4152 4152
Branches 445 445
=======================================
Hits 3774 3774
Misses 372 372
Partials 6 6
Continue to review full report at Codecov.
|
AndyClausen
approved these changes
Jan 16, 2020
bcoe
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792 (comment) by adding
format=fullonto the metadata request.The GCE metadata server in particular does not populate the
emailfield of the ID Token JWT without it.