Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated methods from README #570

Closed
lpellegr opened this issue Dec 15, 2018 · 2 comments
Closed

Update deprecated methods from README #570

lpellegr opened this issue Dec 15, 2018 · 2 comments
Assignees
@JustinBeckwith
Labels
type: docs Improvement to the documentation for an API.

Comments

@lpellegr
Copy link

Version 2 of the library has deprecated several methods.

The README is still showing some examples based on deprecated methods. It would be really convenient to have them replaced by their new equivalent. One example is refreshAccessToken.
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Dec 16, 2018
@clocked0ne clocked0ne mentioned this issue Dec 19, 2018
Closed
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. needs more info This issue needs more information from the customer to proceed. type: docs Improvement to the documentation for an API. labels Dec 20, 2018
@JustinBeckwith
Copy link
Contributor

Greetings! Happy to clean up the README. In the interim - I would like to know more about your usage of the refreshAccessToken method. This is something that should just happen automatically when you call getRequestHeaders, or request. Is there a scenario where you want to manually refresh the token?

@JustinBeckwith JustinBeckwith removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Dec 23, 2018
@lpellegr
Copy link
Author

Hi Justin! I used the refreshAccessToken method with a script in charge of periodically calling a method from the Google Site Verification API in order to automate a flow. This last method has been replaced by getRequestHeaders with success.

The issue was raised mainly to point the fact that some parts of the README are outdated and may confuse people as it was for me when I was looking for a quick alternative call.

Happy holiday season 🎄

@JustinBeckwith JustinBeckwith mentioned this issue Dec 24, 2018
Merged
@JustinBeckwith JustinBeckwith self-assigned this Dec 24, 2018
@JustinBeckwith JustinBeckwith removed the needs more info This issue needs more information from the customer to proceed. label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpellegr @JustinBeckwith