Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Reorganize GAPIC tests #1401

Closed
lukesneeringer opened this issue Jul 5, 2017 · 2 comments
Closed

Reorganize GAPIC tests #1401

lukesneeringer opened this issue Jul 5, 2017 · 2 comments
Assignees

Comments

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Jul 5, 2017

Python smoke tests have recently been added to autogen. Yay!

They are being put in a place where they will never run, though, because the default test loader for unittest requires a test_ prefix for every file.

Right now the directory structure is:

test/
  google/
    cloud/
      {api}/
        {version}/
          {api}_smoketest.py
          test_{client}.py

This should become:

tests/  # Note the -s suffix.
  unit/
    gapic/
      {version}/
        test_{client}.py
  system/
    gapic/
      {version}/
        test_{api}.py

The split for unit/ and system/ is also critical because our test setup in CI knows when to run and not run system tests.

@lukesneeringer
Copy link
Contributor Author

@landrito Assigning to you because I assign all auto-gen things to you. :-) But feel free to reassign if you are not the right person.

@lukesneeringer
Copy link
Contributor Author

Also note the use of "system" and not "smoke". We consistently call them "system tests" in google-cloud-python.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants