Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Self: NoCell bound from AsBytes::write_to #688

Closed
joshlf opened this issue Dec 7, 2023 · 1 comment
Closed

Remove Self: NoCell bound from AsBytes::write_to #688

joshlf opened this issue Dec 7, 2023 · 1 comment

Comments

@joshlf
Copy link
Member

joshlf commented Dec 7, 2023

In #682, we add a Self: NoCell bound to AsBytes::write_to and similar methods. This is technically unnecessary since we should be able to read the bytes of &self in the same way that an &UnsafeCell can be read, but removing the bound will require some manual reimplementation and careful reasoning about soundness.
@joshlf joshlf mentioned this issue Dec 7, 2023
Merged
@joshlf
Copy link
Member Author

joshlf commented Oct 6, 2024

Not sure what I was thinking here, but I'm pretty sure there's no way to do this soundly.

@joshlf joshlf closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf