Skip to content

Commit 0400c06

Browse files
authored
Re-enable Firefox on CI (#324)
Just need to run it with -j 1 (no parallelism) Fixes #292
1 parent 38a6646 commit 0400c06

File tree

1 file changed

+24
-25
lines changed

1 file changed

+24
-25
lines changed

.github/workflows/ci.yaml

+24-25
Original file line numberDiff line numberDiff line change
@@ -60,28 +60,27 @@ jobs:
6060
env:
6161
CHROMEDRIVER_ARGS: '--no-sandbox --headless'
6262

63-
# Disabled; see https://github.com/google/webdriver.dart/issues/292.
64-
# test_firefox:
65-
# runs-on: ${{ matrix.os }}
66-
# strategy:
67-
# fail-fast: false
68-
# matrix:
69-
# os: [ubuntu-latest]
70-
# sdk: [3.4, stable, dev]
71-
# steps:
72-
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
73-
# - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
74-
# with:
75-
# sdk: ${{ matrix.sdk }}
76-
# - uses: browser-actions/setup-firefox@latest
77-
# - uses: browser-actions/setup-geckodriver@eb8b0670366f719ca31703766a8cb7e3ea2c56ed
78-
# - id: install
79-
# name: Install dependencies
80-
# run: dart pub get
81-
# - name: test
82-
# run: |
83-
# export DISPLAY=:99
84-
# geckodriver --port=4445 &
85-
# sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 &
86-
# dart test --tags ff
87-
# if: always() && steps.install.outcome == 'success'
63+
test_firefox:
64+
runs-on: ${{ matrix.os }}
65+
strategy:
66+
fail-fast: false
67+
matrix:
68+
os: [ ubuntu-latest ]
69+
sdk: [ 3.4, stable, dev ]
70+
steps:
71+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
72+
- uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
73+
with:
74+
sdk: ${{ matrix.sdk }}
75+
- uses: browser-actions/setup-firefox@latest
76+
- uses: browser-actions/setup-geckodriver@eb8b0670366f719ca31703766a8cb7e3ea2c56ed
77+
- id: install
78+
name: Install dependencies
79+
run: dart pub get
80+
- name: test
81+
run: |
82+
export DISPLAY=:99
83+
geckodriver --port=4445 &
84+
sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 &
85+
dart test -j 1 --tags ff
86+
if: always() && steps.install.outcome == 'success'

0 commit comments

Comments
 (0)