CRDB Check Broken due to missing the latest (v23.1.14) binary

[roger2hk]

Error Log

2024/01/17 21:59:52 cockroach logs directory: /tmp/cockroach-testserver1754551371
2024/01/17 21:59:52 GET https://binaries.cockroachdb.com/cockroach-v23.1.14.linux-amd64.tgz
2024/01/17 21:59:52 cockroach-go testserver: Failed to fetch latest binary: error downloading https://binaries.cockroachdb.com/cockroach-v23.1.14.linux-amd64.tgz: 404 (404 Not Found) attempting to use cockroach binary from your PATH
E0117 21:59:52.931905    3719 common_test.go:29] Failed to start test server: cockroach-go testserver command cockroach version failed: exec: "cockroach": executable file not found in $PATH
FAIL	github.com/google/trillian/quota/crdbqm	0.175s
FAIL
Error: Process completed with exit code 1.

Root Cause

The test server version is currently pinned to 22.2.7 for /storage/crdb but not /quota/crdbqm/. The latest version is automatically picked for /quota/crdbqm/ test. However, the latest version (v23.1.14) is only available only for CockroachDB Cloud clusters. Thus, the CRDB test checks always failed.

trillian/storage/crdb/common_test.go

Line 46 in 63a7f6c

ts, err := testserver.NewTestServer(testserver.CustomVersionOpt("22.2.7"))

trillian/quota/crdbqm/common_test.go

Line 27 in 63a7f6c

ts, err := testserver.NewTestServer()

[roger2hk]

cc @pav-kv