-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix the wasmtime Rust build #3298
Conversation
This is an attempt to fixup the errors found on google#3292. Although I'm not certain where the error was coming from this switches the Rust installation to being in `PATH` by default so there's no need to `source` any scripts to get access to the Rust compiler.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks @alexcrichton! I continued commenting on this problem over at #3292. Regardless, hopefully this does the trick. |
Hey @alexcrichton, TravisBuddy Request Identifier: c2f69f80-41da-11ea-a094-3d03eb93742b |
This seemed to fix it! |
This is an attempt to fixup the errors found on #3292. Although I'm not
certain where the error was coming from this switches the Rust
installation to being in
PATH
by default so there's no need tosource
any scripts to get access to the Rust compiler.cc @fitzgen, @jfoote, y'all are likely interested in this!