Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix the wasmtime Rust build #3298

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

alexcrichton
Copy link
Contributor

This is an attempt to fixup the errors found on #3292. Although I'm not
certain where the error was coming from this switches the Rust
installation to being in PATH by default so there's no need to
source any scripts to get access to the Rust compiler.

cc @fitzgen, @jfoote, y'all are likely interested in this!

This is an attempt to fixup the errors found on google#3292. Although I'm not
certain where the error was coming from this switches the Rust
installation to being in `PATH` by default so there's no need to
`source` any scripts to get access to the Rust compiler.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@alexcrichton
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jfoote
Copy link
Contributor

jfoote commented Jan 28, 2020

Thanks @alexcrichton! I continued commenting on this problem over at #3292. Regardless, hopefully this does the trick.

@TravisBuddy
Copy link

Hey @alexcrichton,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c2f69f80-41da-11ea-a094-3d03eb93742b

@inferno-chromium inferno-chromium merged commit 96c9cd2 into google:master Jan 28, 2020
@alexcrichton alexcrichton deleted the fix-rust branch January 28, 2020 15:34
@jonathanmetzman
Copy link
Contributor

This seemed to fix it!
I wouldn't be shocked if source broke things. One difference between travis and the actual builds is that in travis we use helper.py (as you would locally) and I think travis uses a fake tty. I wonder if either of these affects whether source can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants