Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasmtime] initial integration #3292

Merged
merged 6 commits into from
Jan 27, 2020
Merged

[wasmtime] initial integration #3292

merged 6 commits into from
Jan 27, 2020

Conversation

jfoote
Copy link
Contributor

@jfoote jfoote commented Jan 24, 2020

Hello all,

This is an initial PR for wasmtime Rust fuzz targets, as discussed on #3285. (Bytecode Alliance tracking issue).

I didn't see clear consensus on whether to use the cargo-fuzz-bundled libfuzzer or linking the oss-fuzz version via LIB_FUZZING_ENGINE_DEPRECATED, so I left the code as-is using LIB_FUZZING_ENGINE_DEPRECATED for now. Pardon if I misunderstood there -- if we should change it for this PR or anytime please just let me know.

cc @fitzgen @jonathanmetzman

Thanks,
Jon

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman
Copy link
Contributor

Will wait for travis to finish to merge

@jonathanmetzman
Copy link
Contributor

Hello all,

This is an initial PR for wasmtime Rust fuzz targets, as discussed on #3285. (Bytecode Alliance tracking issue).

I didn't see clear consensus on whether to use the cargo-fuzz-bundled libfuzzer or linking the oss-fuzz version via LIB_FUZZING_ENGINE_DEPRECATED, so I left the code as-is using LIB_FUZZING_ENGINE_DEPRECATED for now. Pardon if I misunderstood there -- if we should change it for this PR or anytime please just let me know.

Sorry for not being clear. You should leave as is and use LIB_FUZZING_ENGINE_DEPRECATED.

@jonathanmetzman
Copy link
Contributor

I think we want to specify libfuzzer under engines otherwise honggfuzz and afl builds will be done as well.

@jonathanmetzman
Copy link
Contributor

@TravisBuddy
Copy link

Hey @jfoote,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c3720f80-3f05-11ea-9468-7fcc00232609

@jfoote
Copy link
Contributor Author

jfoote commented Jan 27, 2020

If you need anything else here just LMK.

@jonathanmetzman jonathanmetzman merged commit 038d4ac into google:master Jan 27, 2020
@jonathanmetzman
Copy link
Contributor

Don't need anything else. Sorry I didn't get to merge this before the weekend.

@jonathanmetzman
Copy link
Contributor

Looks like build is failing.
https://oss-fuzz-build-logs.storage.googleapis.com/log-336d15f7-d5fb-4db2-ae8a-49e9b990147a.txt

We (OSS-Fuzz devs) probably need to look into this since it passed on travis.

alexcrichton added a commit to alexcrichton/oss-fuzz that referenced this pull request Jan 28, 2020
This is an attempt to fixup the errors found on google#3292. Although I'm not
certain where the error was coming from this switches the Rust
installation to being in `PATH` by default so there's no need to
`source` any scripts to get access to the Rust compiler.
@jfoote
Copy link
Contributor Author

jfoote commented Jan 28, 2020

Thanks for looking into this @jonathanmetzman and @alexcrichton! For posterity, @alexcrichton is taking a shot at fixing this issue in #3298.

The build succeeds for me locally, both for a9febdf (tested previously) and Alex's alexcrichton@1365cfd (tested presently).

It is not clear to me why this is failing. I noted that msan-builder is referenced in the build log but we intended to build the fuzz target only with asan. I'm not sure if that is related to the issue though. It isn't clear to me why building with msan would be generating the error that the build exits on regardless.

inferno-chromium pushed a commit that referenced this pull request Jan 28, 2020
This is an attempt to fixup the errors found on #3292. Although I'm not
certain where the error was coming from this switches the Rust
installation to being in `PATH` by default so there's no need to
`source` any scripts to get access to the Rust compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants