-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasmtime] initial integration #3292
[wasmtime] initial integration #3292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will wait for travis to finish to merge |
Sorry for not being clear. You should leave as is and use LIB_FUZZING_ENGINE_DEPRECATED. |
I think we want to specify libfuzzer under engines otherwise honggfuzz and afl builds will be done as well. |
The libFuzzer ASAN build passed last time: https://travis-ci.org/google/oss-fuzz/jobs/641563087?utm_medium=notification&utm_source=github_status |
Hey @jfoote, TravisBuddy Request Identifier: c3720f80-3f05-11ea-9468-7fcc00232609 |
If you need anything else here just LMK. |
Don't need anything else. Sorry I didn't get to merge this before the weekend. |
Looks like build is failing. We (OSS-Fuzz devs) probably need to look into this since it passed on travis. |
This is an attempt to fixup the errors found on google#3292. Although I'm not certain where the error was coming from this switches the Rust installation to being in `PATH` by default so there's no need to `source` any scripts to get access to the Rust compiler.
Thanks for looking into this @jonathanmetzman and @alexcrichton! For posterity, @alexcrichton is taking a shot at fixing this issue in #3298. The build succeeds for me locally, both for a9febdf (tested previously) and Alex's alexcrichton@1365cfd (tested presently). It is not clear to me why this is failing. I noted that |
This is an attempt to fixup the errors found on #3292. Although I'm not certain where the error was coming from this switches the Rust installation to being in `PATH` by default so there's no need to `source` any scripts to get access to the Rust compiler.
Hello all,
This is an initial PR for wasmtime Rust fuzz targets, as discussed on #3285. (Bytecode Alliance tracking issue).
I didn't see clear consensus on whether to use the cargo-fuzz-bundled libfuzzer or linking the oss-fuzz version via
LIB_FUZZING_ENGINE_DEPRECATED
, so I left the code as-is usingLIB_FUZZING_ENGINE_DEPRECATED
for now. Pardon if I misunderstood there -- if we should change it for this PR or anytime please just let me know.cc @fitzgen @jonathanmetzman
Thanks,
Jon