Skip to content

Commit

Permalink
Use the same fine names for installer when building with Bazel
Browse files Browse the repository at this point in the history
This is another follow up commit to my previous commits [1], which aimed
to start supporting Mozc installer for Windows with Bazel (#948).

In GYP builds we used to have 64 suffix in the file names of Mozc
installers. Let's do the same thing for now to make our build system
transition simpler.

With this commit 'Mozc64_bazel.msi' finally starts showing up on the
GitHub Actions artifacts section.

 [1]: ffc460e
 [2]: b92c4fd

PiperOrigin-RevId: 680747948
  • Loading branch information
yukawa authored and hiroyuki-komatsu committed Sep 30, 2024
1 parent 3a9a56e commit 995d96b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/build_mozc_in_windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ Note that you can specify `--qtdir=` option instead of `--noqt` in GYP phase sin
bazel --bazelrc=windows.bazelrc build --config oss_windows --config release_build package
```

You have release build binaries in `bazel-bin\win32\installer\Mozc.msi`.
You have release build binaries in `bazel-bin\win32\installer\Mozc64.msi`.

---

Expand Down
2 changes: 1 addition & 1 deletion src/win32/installer/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ config_setting(

_WXS_FILE = ":installer_oss_64bit.wxs" if BRANDING == "Mozc" else ":installer_64bit.wxs"

_MSI_FILE = "Mozc.msi" if BRANDING == "Mozc" else "GoogleJapaneseInput.msi"
_MSI_FILE = "Mozc64.msi" if BRANDING == "Mozc" else "GoogleJapaneseInput64.msi"

genrule(
name = "installer",
Expand Down

0 comments on commit 995d96b

Please sign in to comment.