Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto messages from open source protobufs are printed as bytes. #2817

Closed
inazarenko opened this issue Apr 20, 2020 · 3 comments · Fixed by #2818
Closed

Proto messages from open source protobufs are printed as bytes. #2817

inazarenko opened this issue Apr 20, 2020 · 3 comments · Fixed by #2818
Assignees

Comments

@inazarenko
Copy link
Contributor

Open source protobuf messages derive from google::protobuf::MessageLite.

GTest enables ProtbufPrinter based on:

template <typename T>
struct IsAProtocolMessage
   : public std::is_convertible<const T*, const ::proto2::MessageLite*> {};

So open-source protobufs are printed as bytes.

This was previously closed as "inactive": #1102

The issue still occurs at current master.

@inazarenko
Copy link
Contributor Author

Somehow there are two merge commits in the log, and the final result is that the changes from #2818 are not actually present in master at the moment.

Is that intentional? @rogeeff

@asoffer
Copy link
Contributor

asoffer commented May 4, 2020

This was rolled back as it caused conflicts internally. Rather than explicitly forward declaring these things, I think we need an approach that duck-types the messages.

@asoffer
Copy link
Contributor

asoffer commented Nov 3, 2020

This should be fixed at head.

@asoffer asoffer closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants