Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.6 #22

Closed
maffoo opened this issue Jul 7, 2021 · 1 comment · Fixed by #23
Closed

Add support for python 3.6 #22

maffoo opened this issue Jul 7, 2021 · 1 comment · Fixed by #23
Assignees

Comments

@maffoo
Copy link
Collaborator

maffoo commented Jul 7, 2021

We'd like to be able to use duet in python3.6 since it's still used by colab and internally at google (see quantumlib/Cirq#4009). Among other things, this will require adding back in support for AsyncContextManager and adding a 3.6-only dependency on contextvars. There may be some other changes required as well.

@fedimser fedimser self-assigned this Jul 8, 2021
@fedimser
Copy link
Collaborator

fedimser commented Jul 8, 2021

I found other thing which duet uses and which is not available in Python 3.6: postponed evalutaion of annotations (PEP 563). This was added in Python 3.7, so in Python 3.6 statement from __future__ import annotations result in an error.

I am thinking about dropping this, i.e. removing all from __future__ import annotations lines. If I understand correctly how typing works, we just will have to quote type annotations in few places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants