This repository was archived by the owner on Oct 11, 2024. It is now read-only.
[feat] Allow user to set some other vairables. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the variables to every Dockerfile and their description and default values to README.md. |
|
@goofball222 this MR shouldn't be merged anymore since more changes where made to the fork. I'll open a new one if you are willing to merge it. I don't understand why such a simple MR is taking so long... It just adds a few variables that have the same default values as before so it doesn't affect the users who don't want to change them. Any feedback would be appreciated. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2 .
Changes proposed in this pull request:
If you like this approach, I can add this same changes to the other versions (rc, snapshot...) and to the README.md
@goofball222