Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: benchmarks broken by CL 586249 #70647

Closed
neild opened this issue Dec 2, 2024 · 2 comments
Closed

x/net/http2: benchmarks broken by CL 586249 #70647

neild opened this issue Dec 2, 2024 · 2 comments
Assignees
@neild

Comments

@neild
Copy link
Contributor

neild commented Dec 2, 2024 •
edited by gabyhelp
Loading

CL 586249 inadvertently broke some of the x/net/http2 benchmarks. (Oops. Mea culpa.)
@neild neild self-assigned this Dec 2, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/633055 mentions this issue: http2: fix benchmarks using common frame read/write functions

@rittneje
Copy link
Contributor

rittneje commented Dec 2, 2024

@neild Is this a duplicate of #70338?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neild @gopherbot @rittneje