Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: support continuing to work with PRs that are closed and re-opened #40874

Open
randall77 opened this issue Aug 18, 2020 · 1 comment
Open

x/build/cmd/gerritbot: support continuing to work with PRs that are closed and re-opened #40874

randall77 opened this issue Aug 18, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@randall77
Copy link
Contributor

We saw this in CL 239710, where a contributor accidentally closed a PR, reopened it, and was unable to get further updates into gerrit.
@dmitshur @FiloSottile @qingyunha
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 18, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 18, 2020
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 18, 2020
@dmitshur
Copy link
Contributor

We have logic in GerritBot so that a Gerrit CL is automatically abandoned when the PR author closes the PR.

We also have logic so that a GitHub PR is closed when a Gerrit CL is abandoned by a reviewer (including copying the abandon reason to the GitHub PR).

It seems that PRs that are closed and re-opened are not supported. We can use this as the tracking feature to add support for that edge case. Until it's supported, a workaround is to avoid closing PRs or to send a new PR if it happens unintentionally.

/cc @toothrot @andybons @cagedmantis per owners.

@dmitshur dmitshur added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Aug 18, 2020
@dmitshur dmitshur changed the title x/build/cmd/gerritbot: PRs that are closed and re-opened no longer continue to get imported x/build/cmd/gerritbot: no support for PRs that are closed and re-opened Aug 18, 2020
@dmitshur dmitshur changed the title x/build/cmd/gerritbot: no support for PRs that are closed and re-opened x/build/cmd/gerritbot: support continuing to work with PRs that are closed and re-opened Aug 18, 2020
This was referenced Aug 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @randall77 @gopherbot